Bug 119994 - DFG new Array() inlining could get confused about global objects
Summary: DFG new Array() inlining could get confused about global objects
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-08-18 23:22 PDT by Filip Pizlo
Modified: 2013-08-19 15:39 PDT (History)
9 users (show)

See Also:

Attachments
Patch (4.22 KB, patch)
2013-08-18 23:23 PDT, Filip Pizlo 		ggaren: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-ews-01 for mac-mountainlion (890.33 KB, application/zip)
2013-08-19 02:08 PDT, Build Bot 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2013-08-18 23:22:16 PDT 
DFG new Array() inlining could get confused about global objects
Comment 1 Filip Pizlo 2013-08-18 23:23:43 PDT 
Created attachment 209056 [details]
Patch
Comment 2 Build Bot 2013-08-19 02:08:50 PDT 
Comment on attachment 209056 [details]
Patch

Attachment 209056 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/1510437

New failing tests:
fast/js/dfg-cross-global-object-new-array.html
Comment 3 Build Bot 2013-08-19 02:08:52 PDT 
Created attachment 209068 [details]
Archive of layout-test-results from webkit-ews-01 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-01  Port: mac-mountainlion  Platform: Mac OS X 10.8.4
Comment 4 Geoffrey Garen 2013-08-19 09:36:39 PDT 
Comment on attachment 209056 [details]
Patch

r=me
Comment 5 Filip Pizlo 2013-08-19 15:39:30 PDT 
Landed in http://trac.webkit.org/changeset/154304