Bug 119991 - change usage of calculateUTCOffset()/calculateDSTOffset to calculateLocalTimeOffset
Summary: change usage of calculateUTCOffset()/calculateDSTOffset to calculateLocalTim...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Minor
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-08-18 21:04 PDT by Santosh Mahto
Modified: 2013-08-19 23:34 PDT (History)
1 user (show)

See Also:

Attachments
Patch (3.24 KB, patch)
2013-08-18 21:08 PDT, Santosh Mahto 		no flags Details | Formatted Diff | Diff
Patch (3.25 KB, patch)
2013-08-18 21:56 PDT, Santosh Mahto 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Santosh Mahto 2013-08-18 21:04:50 PDT 
calculateUTCOffset()/calculateDSTOffset  these two function has been made static in changelist  http://trac.webkit.org/changeset/150833
Using these function in other file is wrong and will give compile time error.

Instead  calculateLocalTimeOffset should be used.
Comment 1 Santosh Mahto 2013-08-18 21:08:59 PDT 
Created attachment 209047 [details]
Patch
Comment 2 Santosh Mahto 2013-08-18 21:56:19 PDT 
Created attachment 209052 [details]
Patch
Comment 3 Darin Adler 2013-08-18 23:01:45 PDT 
Comment on attachment 209052 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=209052&action=review

> Source/WebCore/ChangeLog:7
> +        Resolving code error.

What kind of code error? I don’t understand the reason behind this change. Is this more elegant? More correct? Both? If more correct, was there a test that was failing?
Comment 4 Darin Adler 2013-08-18 23:02:16 PDT 
Comment on attachment 209052 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=209052&action=review

>> Source/WebCore/ChangeLog:7
>> +        Resolving code error.
> 
> What kind of code error? I don’t understand the reason behind this change. Is this more elegant? More correct? Both? If more correct, was there a test that was failing?

Oh, I see, you mean this resolves a build failure? Got it.
Comment 5 Santosh Mahto 2013-08-18 23:16:18 PDT 
(In reply to comment #4)
> (From update of attachment 209052 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=209052&action=review
> 
> >> Source/WebCore/ChangeLog:7
> >> +        Resolving code error.
> > 
> > What kind of code error? I don’t understand the reason behind this change. Is this more elegant? More correct? Both? If more correct, was there a test that was failing?
> 
> Oh, I see, you mean this resolves a build failure? Got it.

Right, Build will fail when input type date/time/month is enabled.
Comment 6 WebKit Commit Bot 2013-08-19 23:34:39 PDT 
Comment on attachment 209052 [details]
Patch

Clearing flags on attachment: 209052

Committed r154315: <http://trac.webkit.org/changeset/154315>
Comment 7 WebKit Commit Bot 2013-08-19 23:34:40 PDT 
All reviewed patches have been landed.  Closing bug.