Bug 119962 – DFG should inline typedArray.byteOffset

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Filip Pizlo]

Patch forthcoming.

[Filip Pizlo]

Created attachment 209011 [details]
work in progress

Almost done.

[Filip Pizlo]

Created attachment 209017 [details]
the patch

[Oliver Hunt]

Comment on attachment 209017 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=209017&action=review

> LayoutTests/fast/js/regress/script-tests/ArrayBuffer-Int32Array-byteOffset.js:9
> +for (var i = 0; i < 1000000; ++i) {
> +    result += array1.byteOffset;
> +    result += array2.byteOffset;
> +}

Is it possible to have a similar test that neuters midway through?

[Filip Pizlo]

(In reply to comment #3)
> (From update of attachment 209017 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=209017&action=review
> 
> > LayoutTests/fast/js/regress/script-tests/ArrayBuffer-Int32Array-byteOffset.js:9
> > +for (var i = 0; i < 1000000; ++i) {
> > +    result += array1.byteOffset;
> > +    result += array2.byteOffset;
> > +}
> 
> Is it possible to have a similar test that neuters midway through?

Oh yeah!

I'm not sure it's meaningful to have a performance test (all operations on views run the same code whether it's neutered or not), but I definitely should add a correctness test to make sure that when neutered, the pointer indirections and subtractions work.

[Filip Pizlo]

Created attachment 209053 [details]
almost patch for landing

[Filip Pizlo]

(In reply to comment #5)
> Created an attachment (id=209053) [details]
> almost patch for landing

Still need to generate expected file for one of the new tests.

[Build Bot]

Comment on attachment 209053 [details]
almost patch for landing

Attachment 209053 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/1478819

New failing tests:
fast/js/dfg-byteOffset-neuter.html

[Build Bot]

Created attachment 209070 [details]
Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-16  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.4

[Filip Pizlo]

Landed in http://trac.webkit.org/changeset/154305