WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
119960
Remove some optimizations made obsolete by use of StringBuilder
https://bugs.webkit.org/show_bug.cgi?id=119960
Summary
Remove some optimizations made obsolete by use of StringBuilder
Antti Koivisto
Reported
2013-08-17 14:36:27 PDT
Foo.
Attachments
pathc
(3.24 KB, patch)
2013-08-17 14:41 PDT
,
Antti Koivisto
kling
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Antti Koivisto
Comment 1
2013-08-17 14:41:54 PDT
Created
attachment 209009
[details]
pathc
Andreas Kling
Comment 2
2013-08-17 14:48:02 PDT
Comment on
attachment 209009
[details]
pathc View in context:
https://bugs.webkit.org/attachment.cgi?id=209009&action=review
r=me with the cool stories we shared on IRC. We should clean this up in StyleElement::process(), too.
> Source/WebCore/dom/ScriptElement.cpp:399 > + for (Text* textNode = TextNodeTraversal::firstChild(m_element); textNode; textNode = TextNodeTraversal::nextSibling(textNode)) > + content.append(textNode->data());
Can't you use TextNodeTraversal::contentsAsString() instead here?
Antti Koivisto
Comment 3
2013-08-17 15:04:51 PDT
https://trac.webkit.org/r154241
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug