Bug 119953 - Tries to fetch plugins information once and again when plugin process fails
Summary: Tries to fetch plugins information once and again when plugin process fails
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL: https://bugzilla.gnome.org/show_bug.c...
Keywords:
Depends on:
Blocks:
 
Reported: 2013-08-17 10:09 PDT by Claudio Saavedra
Modified: 2013-08-17 10:09 PDT (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Claudio Saavedra 2013-08-17 10:09:37 PDT
This is problematic when GetPlugins fails somehow:

void WebPlatformStrategies::populatePluginCache()
{
    if (m_pluginCacheIsPopulated)
        return;

    ASSERT(m_cachedPlugins.isEmpty());

    // FIXME: Should we do something in case of error here?
    if
(!WebProcess::shared().parentProcessConnection()->sendSync(Messages::WebProcessProxy::GetPlugins(m_shouldRefreshPlugins),
Messages::WebProcessProxy::GetPlugins::Reply(m_cachedPlugins,
m_cachedApplicationPlugins), 0))
        return;

    m_shouldRefreshPlugins = false;
    m_pluginCacheIsPopulated = true;
}

If this fails we shouldn't be checking once an again.