Bug 119946 - Move some code used only by EventHandler from Clipboard to EventHandler
Summary: Move some code used only by EventHandler from Clipboard to EventHandler
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: UI Events (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Darin Adler
URL:
Keywords:
Depends on:
Blocks: 115980
  Show dependency treegraph
 
Reported: 2013-08-17 07:14 PDT by Darin Adler
Modified: 2013-08-20 09:48 PDT (History)
3 users (show)

See Also:


Attachments
Patch (8.08 KB, patch)
2013-08-17 07:18 PDT, Darin Adler
kling: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2013-08-17 07:14:30 PDT
Move some code used only by EventHandler from Clipboard to EventHandler
Comment 1 Darin Adler 2013-08-17 07:18:36 PDT
Created attachment 208995 [details]
Patch
Comment 2 Andreas Kling 2013-08-17 07:38:47 PDT
Comment on attachment 208995 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=208995&action=review

r=me

> Source/WebCore/page/EventHandler.cpp:2037
> +static inline bool hasFileOfType(Clipboard* clipboard, const String& type)

I'd use Clipboard& here.

> Source/WebCore/page/EventHandler.cpp:2047
> +static inline bool hasStringOfType(Clipboard* clipboard, const String& type)

Ditto.

> Source/WebCore/page/EventHandler.cpp:2052
> +static bool hasDropZoneType(Clipboard* clipboard, const String& keyword)

Ditto.
Comment 3 Darin Adler 2013-08-17 07:55:38 PDT
Committed r154229: <http://trac.webkit.org/changeset/154229>