Bug 119933 - [Qt] Fix tst_QObjectBridge::connectAndDisconnect() fail
Summary: [Qt] Fix tst_QObjectBridge::connectAndDisconnect() fail
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2013-08-16 22:13 PDT by Arunprasad Rajkumar
Modified: 2013-08-19 03:59 PDT (History)
6 users (show)

See Also:

Patch (2.78 KB, patch)
2013-08-16 22:22 PDT, Arunprasad Rajkumar
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Arunprasad Rajkumar 2013-08-16 22:13:35 PDT
FAIL!  : tst_QObjectBridge::connectAndDisconnect() Compared values are not the same
   Actual   (ret): TypeError: undefined is not a function (evaluating '(function() { }).connect()')
   Expected (QLatin1String("TypeError: 'undefined' is not a function (evaluating '(function() { }).connect()')")): TypeError: 'undefined' is not a function (evaluating '(function() { }).connect()')
   Loc: [/ramdisk/qt-linux-release/build/Source/WebKit/qt/tests/qobjectbridge/tst_qobjectbridge.cpp(1575)]

The issue is due to wrong exception string comparison. 

Calling undefined method on a object will raise TypeError: undefined is not a function ...,

undefined is not inside single quote(').
Comment 1 Arunprasad Rajkumar 2013-08-16 22:22:38 PDT
Created attachment 208977 [details]
Comment 2 WebKit Commit Bot 2013-08-19 03:59:01 PDT
Comment on attachment 208977 [details]

Clearing flags on attachment: 208977

Committed r154273: <http://trac.webkit.org/changeset/154273>
Comment 3 WebKit Commit Bot 2013-08-19 03:59:05 PDT
All reviewed patches have been landed.  Closing bug.