Bug 11993 - REGRESSION(r18320): Web Inspector scroll bars not drawn
Summary: REGRESSION(r18320): Web Inspector scroll bars not drawn
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 420+
Hardware: Mac OS X 10.4
: P2 Normal
Assignee: Nobody
Keywords: InRadar, Regression
Depends on:
Reported: 2006-12-27 00:57 PST by Matt Lilek
Modified: 2006-12-27 16:02 PST (History)
2 users (show)

See Also:

attempted patch (1.50 KB, patch)
2006-12-27 00:58 PST, Matt Lilek
no flags Details | Formatted Diff | Diff
better patch (2.45 KB, patch)
2006-12-27 09:04 PST, Matt Lilek
timothy: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Lilek 2006-12-27 00:57:14 PST
The Javascript error changes in r18320 caused the web inspector's scroll bars to not draw and spew DOM Exception 12 errors in the console.

From what I can tell, this was caused by AppleVerticalScrollbar's computeTrackLength method sometimes returning NaN which totally throws off all the calculations based on that and it eventually trys to set NaN as the scroll bar height in the _setObjectLength method (which WebKit didn't care about before the change).

My patch overrides the _setObjectLength method and checks if length is a number before setting it which fixes it (on Tiger at least, don't know about what changes have been made to this on Leopard, though I doubt this breaks anything).
Comment 1 Matt Lilek 2006-12-27 00:58:38 PST
Created attachment 12054 [details]
attempted patch
Comment 2 Matt Lilek 2006-12-27 01:42:17 PST
This fix would probably be better off in inspector.js with a note about why its there wouldn't it?  I'll leave it up for comments on the logic and upload a new patch in the morning..
Comment 3 Mark Rowe (bdash) 2006-12-27 02:42:49 PST
Matt, can you file a bug in radar at http://bugreporter.apple.com/ mentioning the breakage that this covers so that it can be tracked internally by Apple?
Comment 4 Matt Lilek 2006-12-27 08:35:21 PST
Filed as radar 4901491
Comment 5 Matt Lilek 2006-12-27 09:04:49 PST
Created attachment 12061 [details]
better patch
Comment 6 Sam Weinig 2006-12-27 16:02:31 PST
Landed in r18444.