Bug 119923 - RenderNamedFlowThread should not create NodeRenderingContext objects
Summary: RenderNamedFlowThread should not create NodeRenderingContext objects
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mihai Maerean
URL:
Keywords: BlinkMergeCandidate
Depends on:
Blocks:
 
Reported: 2013-08-16 20:02 PDT by Ryosuke Niwa
Modified: 2013-08-22 08:27 PDT (History)
17 users (show)

See Also:

Attachments
Patch (2.67 KB, patch)
2013-08-22 05:10 PDT, Andrei Bucur 		no flags Details | Formatted Diff | Diff
Patch (2.60 KB, patch)
2013-08-22 06:16 PDT, Andrei Bucur 		no flags Details | Formatted Diff | Diff
Patch (2.77 KB, patch)
2013-08-22 07:07 PDT, Andrei Bucur 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2013-08-16 20:02:38 PDT 
Consider merging https://chromium.googlesource.com/chromium/blink/+/949d7d7e7b8685454742a55cf0ca912bb9a7b177

RenderNamedFlowThread is using NodeRenderingContext to get the original
parent renderer, but should just be using NodeRenderingTraversal::parent
instead (which is what NodeRenderingContext does internally anyway).
Comment 1 Andrei Bucur 2013-08-22 05:10:10 PDT 
Created attachment 209350 [details]
Patch
Comment 2 Build Bot 2013-08-22 05:14:23 PDT 
Comment on attachment 209350 [details]
Patch

Attachment 209350 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/1545097
Comment 3 Antti Koivisto 2013-08-22 05:14:58 PDT 
Comment on attachment 209350 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=209350&action=review

> Source/WebCore/rendering/RenderNamedFlowThread.cpp:486
> +    NodeRenderingTraversal::ParentDetails parentDetails;

I killed ParentDetails so this is not going to work. The equivalent code is likely to be simple though.
Comment 4 Antti Koivisto 2013-08-22 05:16:52 PDT 
Or you can just leave this to be for now. I'm going to remove NodeRenderingContext.
Comment 5 Andrei Bucur 2013-08-22 06:16:03 PDT 
Created attachment 209358 [details]
Patch
Comment 6 Early Warning System Bot 2013-08-22 06:29:23 PDT 
Comment on attachment 209358 [details]
Patch

Attachment 209358 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/1525634
Comment 7 EFL EWS Bot 2013-08-22 06:34:34 PDT 
Comment on attachment 209358 [details]
Patch

Attachment 209358 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/1384980
Comment 8 Early Warning System Bot 2013-08-22 06:34:43 PDT 
Comment on attachment 209358 [details]
Patch

Attachment 209358 [details] did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/1426086
Comment 9 kov's GTK+ EWS bot 2013-08-22 06:41:29 PDT 
Comment on attachment 209358 [details]
Patch

Attachment 209358 [details] did not pass gtk-ews (gtk):
Output: http://webkit-queues.appspot.com/results/1538089
Comment 10 Build Bot 2013-08-22 06:45:29 PDT 
Comment on attachment 209358 [details]
Patch

Attachment 209358 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/1549088
Comment 11 EFL EWS Bot 2013-08-22 06:52:22 PDT 
Comment on attachment 209358 [details]
Patch

Attachment 209358 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/1380555
Comment 12 Build Bot 2013-08-22 06:58:35 PDT 
Comment on attachment 209358 [details]
Patch

Attachment 209358 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/1538091
Comment 13 Andrei Bucur 2013-08-22 07:07:50 PDT 
Created attachment 209362 [details]
Patch
Comment 14 Antti Koivisto 2013-08-22 08:01:16 PDT 
Comment on attachment 209362 [details]
Patch

r=me
Comment 15 WebKit Commit Bot 2013-08-22 08:27:30 PDT 
Comment on attachment 209362 [details]
Patch

Clearing flags on attachment: 209362

Committed r154447: <http://trac.webkit.org/changeset/154447>
Comment 16 WebKit Commit Bot 2013-08-22 08:27:34 PDT 
All reviewed patches have been landed.  Closing bug.