Bug 119910 - [Windows] Update RenderMediaControls for new API
Summary: [Windows] Update RenderMediaControls for new API
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-08-16 13:20 PDT by Brent Fulgham
Modified: 2013-08-16 14:44 PDT (History)
7 users (show)

See Also:

Attachments
Patch (10.16 KB, patch)
2013-08-16 14:05 PDT, Brent Fulgham 		no flags Details | Formatted Diff | Diff
Patch (10.30 KB, patch)
2013-08-16 14:26 PDT, Brent Fulgham 		eric.carlson: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2013-08-16 13:20:25 PDT 
The RenderMediaControls::paintMediaControlsPart and RenderMediaControls::adjustMediaSliderThumbSize implementations need to be updated to match the new WebKitSystemInterface API for drawing rendering controls.
Comment 1 Brent Fulgham 2013-08-16 14:05:38 PDT 
Created attachment 208955 [details]
Patch
Comment 2 Eric Carlson 2013-08-16 14:17:38 PDT 
Comment on attachment 208955 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=208955&action=review

> Source/WebCore/rendering/RenderMediaControls.cpp:57
> +#if HAVE(AVCF_LEGIBLE_OUTPUT) // i.e., the new media controls
> +#define wkHitTestMediaUIPart(part, bounds, point) WKHitTestMediaUIPart(part, bounds, point)
> +#define wkMeasureMediaUIPart(part, bounds, naturalSize) WKMeasureMediaUIPart(part, bounds, naturalSize)
> +#define wkDrawMediaUIPart(part, context, rect, state) WKDrawMediaUIPart(part, context, rect, state)
> +#define wkDrawMediaSliderTrack(context, rect, timeLoaded, currentTime, duration, state) WKDrawMediaSliderTrack(context, rect, timeLoaded, currentTime, duration, state)
> +#else
> +// This is needed until WebKitSystemInterface is updated on the build machines
> +#define wkHitTestMediaUIPart(part, bounds, point) WKHitTestMediaUIPart(part, WKMediaControllerThemeQuickTime, bounds, point)
> +#define wkMeasureMediaUIPart(part, bounds, naturalSize) WKMeasureMediaUIPart(part, WKMediaControllerThemeQuickTime, bounds, naturalSize)
> +#define wkDrawMediaUIPart(part, context, rect, state) WKDrawMediaUIPart(part, WKMediaControllerThemeQuickTime, context, rect, state)
> +#define wkDrawMediaSliderTrack(context, rect, timeLoaded, currentTime, duration, state) WKDrawMediaSliderTrack(WKMediaControllerThemeQuickTime, context, rect, timeLoaded, currentTime, duration, state)
> +#endif

This might be slightly cleaner as inline functions instead of #defines.
Comment 3 Brent Fulgham 2013-08-16 14:26:24 PDT 
Created attachment 208960 [details]
Patch
Comment 4 Eric Carlson 2013-08-16 14:42:00 PDT 
Comment on attachment 208960 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=208960&action=review

Thank you!

> Source/WebCore/rendering/RenderMediaControls.cpp:48
> +#if HAVE(AVCF_LEGIBLE_OUTPUT) // i.e., the new media controls

The comment isn't necessary, here or in the other the functions.
Comment 5 Brent Fulgham 2013-08-16 14:44:30 PDT 
Committed r154205: <http://trac.webkit.org/changeset/154205>