Bug 119909 - DFG should optimize typedArray.byteLength
Summary: DFG should optimize typedArray.byteLength
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-08-16 13:03 PDT by Filip Pizlo
Modified: 2013-08-16 22:49 PDT (History)
8 users (show)

See Also:

Attachments
the patch (23.97 KB, patch)
2013-08-16 13:06 PDT, Filip Pizlo 		oliver: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2013-08-16 13:03:39 PDT 
Patch forthcoming.
Comment 1 Filip Pizlo 2013-08-16 13:06:47 PDT 
Created attachment 208949 [details]
the patch
Comment 2 WebKit Commit Bot 2013-08-16 13:09:14 PDT 
Attachment 208949 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast/js/regress/Int16Array-bubble-sort-with-byteLength-expected.txt', u'LayoutTests/fast/js/regress/Int16Array-bubble-sort-with-byteLength.html', u'LayoutTests/fast/js/regress/Int8Array-load-with-byteLength-expected.txt', u'LayoutTests/fast/js/regress/Int8Array-load-with-byteLength.html', u'LayoutTests/fast/js/regress/script-tests/Int16Array-bubble-sort-with-byteLength.js', u'LayoutTests/fast/js/regress/script-tests/Int8Array-load-with-byteLength.js', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/bytecode/SpeculatedType.cpp', u'Source/JavaScriptCore/bytecode/SpeculatedType.h', u'Source/JavaScriptCore/dfg/DFGArrayMode.cpp', u'Source/JavaScriptCore/dfg/DFGArrayMode.h', u'Source/JavaScriptCore/dfg/DFGFixupPhase.cpp', u'Source/JavaScriptCore/dfg/DFGGraph.h', u'Source/JavaScriptCore/runtime/TypedArrayType.h']" exit_code: 1
Source/JavaScriptCore/dfg/DFGArrayMode.cpp:495:  Extra space between return and Array  [whitespace/declaration] [3]
Total errors found: 1 in 15 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Oliver Hunt 2013-08-16 13:22:01 PDT 
Comment on attachment 208949 [details]
the patch

r=me, fix the style error
Comment 4 Filip Pizlo 2013-08-16 13:23:57 PDT 
(In reply to comment #3)
> (From update of attachment 208949 [details])
> r=me, fix the style error

Thanks, fixed.
Comment 5 Filip Pizlo 2013-08-16 22:49:50 PDT 
Landed in http://trac.webkit.org/changeset/154218