RESOLVED FIXED 119909
DFG should optimize typedArray.byteLength 
https://bugs.webkit.org/show_bug.cgi?id=119909
Summary DFG should optimize typedArray.byteLength
Filip Pizlo
Reported 2013-08-16 13:03:39 PDT
Patch forthcoming.
Attachments
the patch (23.97 KB, patch)
2013-08-16 13:06 PDT, Filip Pizlo 		oliver: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2013-08-16 13:06:47 PDT
Created attachment 208949 [details] the patch
WebKit Commit Bot
Comment 2 2013-08-16 13:09:14 PDT
Attachment 208949 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast/js/regress/Int16Array-bubble-sort-with-byteLength-expected.txt', u'LayoutTests/fast/js/regress/Int16Array-bubble-sort-with-byteLength.html', u'LayoutTests/fast/js/regress/Int8Array-load-with-byteLength-expected.txt', u'LayoutTests/fast/js/regress/Int8Array-load-with-byteLength.html', u'LayoutTests/fast/js/regress/script-tests/Int16Array-bubble-sort-with-byteLength.js', u'LayoutTests/fast/js/regress/script-tests/Int8Array-load-with-byteLength.js', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/bytecode/SpeculatedType.cpp', u'Source/JavaScriptCore/bytecode/SpeculatedType.h', u'Source/JavaScriptCore/dfg/DFGArrayMode.cpp', u'Source/JavaScriptCore/dfg/DFGArrayMode.h', u'Source/JavaScriptCore/dfg/DFGFixupPhase.cpp', u'Source/JavaScriptCore/dfg/DFGGraph.h', u'Source/JavaScriptCore/runtime/TypedArrayType.h']" exit_code: 1 Source/JavaScriptCore/dfg/DFGArrayMode.cpp:495: Extra space between return and Array [whitespace/declaration] [3] Total errors found: 1 in 15 files If any of these errors are false positives, please file a bug against check-webkit-style.
Oliver Hunt
Comment 3 2013-08-16 13:22:01 PDT
Comment on attachment 208949 [details] the patch r=me, fix the style error
Filip Pizlo
Comment 4 2013-08-16 13:23:57 PDT
(In reply to comment #3) > (From update of attachment 208949 [details]) > r=me, fix the style error Thanks, fixed.
Filip Pizlo
Comment 5 2013-08-16 22:49:50 PDT
Landed in http://trac.webkit.org/changeset/154218
Note You need to log in before you can comment on or make changes to this bug.