Bug 119908 – [CSS Masking] Build without CSS features broken after r154174

• Status: RESOLVED
• Resolution: DUPLICATE
• Component: WebCore Misc.

[Zoltan Arvai]

It seems some guards are missing after adding and parsing of the mask-type property.

Build on Qt Linux Release minimal bot is broken. All CSS features are disabled on this one:

CSS Device Adaptation ......... no
CSS Exclusions ................ no
CSS Shapes .................... no
CSS Filters ................... no
CSS3 Conditional Rules support (i.e. @supports)  no
CSS3 Text ..................... no
CSS3 Text Line Break .......... no
CSS box-decoration-break ...... no
CSS image-orientation ......... no
CSS image-resolution .......... no
CSS image-set ................. no
CSS Regions ................... no
CSS Shaders ................... no
CSS sticky position ........... no
CSS Compositing ............... no
Support for unprefixed CSS animations and transforms  no
CSS Variable .................. no

Details from the build log:

http://build.webkit.org/builders/Qt%20Linux%20Release%20minimal/builds/80916

/ramdisk/qt-linux-release-minimal/build/Source/WebCore/css/CSSComputedStyleDeclaration.cpp: In function 'WTF::PassRefPtr<WebCore::CSSValue> WebCore::fillSourceTypeToCSSValue(WebCore::EMaskSourceType)':
/ramdisk/qt-linux-release-minimal/build/Source/WebCore/css/CSSComputedStyleDeclaration.cpp:1431:43: error: 'CSSValueAlpha' was not declared in this scope
/ramdisk/qt-linux-release-minimal/build/Source/WebCore/css/CSSComputedStyleDeclaration.cpp:1433:43: error: 'CSSValueLuminance' was not declared in this scope

And some more detail, after local build:

/home/azbest/webkit/WebKit/Source/WebCore/css/CSSParser.cpp:4433:63: error: 'CSSValueAlpha' was not declared in this scope
/home/azbest/webkit/WebKit/Source/WebCore/css/CSSParser.cpp:4433:91: error: 'CSSValueLuminance' was not declared in this scope

/home/azbest/webkit/WebKit/Source/WebCore/css/CSSToStyleMap.cpp:315:10: error: 'CSSValueAlpha' was not declared in this scope
/home/azbest/webkit/WebKit/Source/WebCore/css/CSSToStyleMap.cpp:318:10: error: 'CSSValueLuminance' was not declared in this scope

[Arunprasad Rajkumar]

Already fixed in https://bugs.webkit.org/show_bug.cgi?id=119912(sorry, i didn't notice this bug, otherwise i might have submitted a patch here)

[Zoltan Arvai]

Thanks for fixing it :)

*** This bug has been marked as a duplicate of bug 119912 ***