Bug 11990 - Split out PDFDocument logic into Image subclass
: Split out PDFDocument logic into Image subclass
Status: RESOLVED FIXED
Product: WebKit
Classification: Unclassified
Component: Platform
: 420+
: Macintosh Mac OS X 10.4
: P2 Normal
Assigned To: Eric Seidel
:
Depends on:
Blocks: 5971
  Show dependency treegraph
 
Reported: 2006-12-26 23:55 PST by Eric Seidel
Modified: 2006-12-28 11:27 PST (History)
1 user (show)

See Also:


Attachments
patch to actually do the split (50.24 KB, patch)
2006-12-27 00:37 PST, Eric Seidel
oliver: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel 2006-12-26 23:55:33 PST
Split out PDFDocument logic into Image subclass

This is all in preparation for adding SVGImage.
Comment 1 Eric Seidel 2006-12-27 00:37:56 PST
Created attachment 12053 [details]
patch to actually do the split

This one is for real.  I've run the layout tests (and added some -- already landed).  I've surfed with this a bit.  It's possible this could affect performance, but I don't have any good way of testing that.  Ideally hyatt should look at this.
Comment 2 Oliver Hunt 2006-12-27 01:00:52 PST
Comment on attachment 12053 [details]
patch to actually do the split

looks good, can you delay landing for a day or so?
Comment 3 Eric Seidel 2006-12-27 01:22:21 PST
Ideally hyatt should at least glance at this patch as well.
Comment 4 Sam Weinig 2006-12-28 11:27:55 PST
Landed in r18446.