Bug 119891 - [WinCairo] Compile error.
Summary: [WinCairo] Compile error.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-08-16 04:32 PDT by peavo
Modified: 2013-08-16 12:19 PDT (History)
6 users (show)

See Also:

Attachments
Patch (1.43 KB, patch)
2013-08-16 04:41 PDT, peavo 		no flags Details | Formatted Diff | Diff
Patch (2.01 KB, patch)
2013-08-16 11:39 PDT, peavo 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description peavo 2013-08-16 04:32:06 PDT 
Compiling WinCairo fails with:

..\rendering\FlowThreadController.cpp(274): error C2039: 'updateLayerToRegionMappingsIfNeeded' : is not a member of 'WebCore::RenderNamedFlowThread' c:\cygwin\home\per.arne.vollan\webkit\source\webcore\rendering\RenderNamedFlowThread.h(46) : see declaration of 'WebCore::RenderNamedFlowThread'
Comment 1 peavo 2013-08-16 04:41:12 PDT 
Created attachment 208913 [details]
Patch
Comment 2 Mihnea Ovidenie 2013-08-16 06:33:24 PDT 
Comment on attachment 208913 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=208913&action=review

> Source/WebCore/rendering/FlowThreadController.cpp:270
>  void FlowThreadController::updateRenderFlowThreadLayersIfNeeded()

Please guard the declaration of this method in FlowThreadController.h too.
Comment 3 peavo 2013-08-16 11:39:49 PDT 
Created attachment 208937 [details]
Patch
Comment 4 Brent Fulgham 2013-08-16 11:49:37 PDT 
Comment on attachment 208937 [details]
Patch

r=me
Comment 5 WebKit Commit Bot 2013-08-16 12:19:31 PDT 
Comment on attachment 208937 [details]
Patch

Clearing flags on attachment: 208937

Committed r154200: <http://trac.webkit.org/changeset/154200>
Comment 6 WebKit Commit Bot 2013-08-16 12:19:33 PDT 
All reviewed patches have been landed.  Closing bug.