Bug 119882 - Speed up moving cursor/selection up or down past non-rendered elements.
Summary: Speed up moving cursor/selection up or down past non-rendered elements.
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
: 119350 (view as bug list)
Depends on:
Reported: 2013-08-16 01:33 PDT by Mario Sanchez Prada
Modified: 2013-08-19 22:50 PDT (History)
5 users (show)

See Also:

Patch proposal plus new Layout test (8.18 KB, patch)
2013-08-16 02:14 PDT, Mario Sanchez Prada
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mario Sanchez Prada 2013-08-16 01:33:38 PDT
According to blink bug https://codereview.chromium.org/20049007, right now you webkit can eventually perform a O(n^2) scan through the document when moving the cursor up when at
the beginning of a document, which is pretty bad not only when in design mode or in editable elements, but also when you have enabled the caret browsing mode (EFL & GTK ports).
Comment 1 Mario Sanchez Prada 2013-08-16 02:14:34 PDT
Created attachment 208895 [details]
Patch proposal plus new Layout test

Attaching patch proposal, as backported from https://src.chromium.org/viewvc/blink?revision=154977&view=revision

As in the case of blink (and as per Dominic's comment during the review process), the newly added test runs *very* fast (constant time) when the bug is
fixed, and times out otherwise.
Comment 2 Mario Sanchez Prada 2013-08-18 11:28:12 PDT
Thanks for the review, Darin. Unfortunately, I'm on holidays now and with no access to my devel machine until September the 3rd, meaning that I won't be able to commit this (or anything else) until then.

Anyway, feel free to commit it yourself if you don't want to wait two weeks. Otherwise I'll do it right away once I'm back.

Comment 3 WebKit Commit Bot 2013-08-19 04:11:33 PDT
Comment on attachment 208895 [details]
Patch proposal plus new Layout test

Clearing flags on attachment: 208895

Committed r154274: <http://trac.webkit.org/changeset/154274>
Comment 4 WebKit Commit Bot 2013-08-19 04:11:36 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Darin Adler 2013-08-19 08:47:31 PDT
*** Bug 119350 has been marked as a duplicate of this bug. ***