Bug 119880 - [Qt] Build fix (broken since r154142)
Summary: [Qt] Build fix (broken since r154142)
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-08-16 00:32 PDT by Julien Brianceau
Modified: 2013-08-16 01:51 PDT (History)
3 users (show)

See Also:

Attachments
[Qt] Trivial build fix (1.22 KB, patch)
2013-08-16 00:35 PDT, Julien Brianceau 		gyuyoung.kim: review+
Details | Formatted Diff | Diff
[Qt] Build fix (1.24 KB, patch)
2013-08-16 01:06 PDT, Julien Brianceau 		gyuyoung.kim: review+
Details | Formatted Diff | Diff
[Qt] Build fix (with description in ChangeLog) (1.32 KB, patch)
2013-08-16 01:20 PDT, Julien Brianceau 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Julien Brianceau 2013-08-16 00:32:34 PDT 
Our sh4 build bot is broken since r154142: http://build.webkit.org/builders/Qt%20Linux%20SH4%20Release/builds/28747

/local/wkit/slavebuildbot_LOCAL/workspace_LOCAL/qt-linux-sh4-release/build/Source/WebCore/xml/parser/XMLDocumentParserQt.cpp: In member function 'void WebCore::XMLDocumentParser::parseStartElement()':
/local/wkit/slavebuildbot_LOCAL/workspace_LOCAL/qt-linux-sh4-release/build/Source/WebCore/xml/parser/XMLDocumentParserQt.cpp:508:38: error: base operand of '->' has non-pointer type 'WebCore::FrameLoader'
make[3]: *** [.obj/release-shared/xml/parser/XMLDocumentParserQt.o] Error 1
Comment 1 Julien Brianceau 2013-08-16 00:35:29 PDT 
Created attachment 208887 [details]
[Qt] Trivial build fix
Comment 2 Julien Brianceau 2013-08-16 01:06:18 PDT 
Created attachment 208889 [details]
[Qt] Build fix
Comment 3 Julien Brianceau 2013-08-16 01:20:41 PDT 
Created attachment 208892 [details]
[Qt] Build fix (with description in ChangeLog)
Comment 4 WebKit Commit Bot 2013-08-16 01:34:41 PDT 
The commit-queue encountered the following flaky tests while processing attachment 208887 [details]:

http/tests/navigation/ping-cross-origin-from-https.html bug 51314 (authors: japhet@chromium.org and rniwa@webkit.org)
The commit-queue is continuing to process your patch.
Comment 5 WebKit Commit Bot 2013-08-16 01:51:37 PDT 
Comment on attachment 208892 [details]
[Qt] Build fix (with description in ChangeLog)

Clearing flags on attachment: 208892

Committed r154168: <http://trac.webkit.org/changeset/154168>
Comment 6 WebKit Commit Bot 2013-08-16 01:51:40 PDT 
All reviewed patches have been landed.  Closing bug.