Bug 119879 - [sh4] Fix sh4 build after r154156
Summary: [sh4] Fix sh4 build after r154156
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-08-16 00:15 PDT by Julien Brianceau
Modified: 2013-08-16 02:24 PDT (History)
5 users (show)

See Also:

Attachments
sh4 build fix (1.65 KB, patch)
2013-08-16 00:20 PDT, Julien Brianceau 		no flags Details | Formatted Diff | Diff
sh4 build fix (1.27 KB, patch)
2013-08-16 01:13 PDT, Julien Brianceau 		no flags Details | Formatted Diff | Diff
sh4 build fix (with description in ChangeLog) (1.31 KB, patch)
2013-08-16 01:28 PDT, Julien Brianceau 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Julien Brianceau 2013-08-16 00:15:38 PDT 
sh4 build is broken since r154156:

/local/wkit/slavebuildbot_LOCAL/workspace_LOCAL/qt-linux-sh4-release/build/WebKitBuild/Release/Source/JavaScriptCore/release/libJavaScriptCore.a(JITArithmetic32_64.o): In function `JSC::JITSlowPathCall::call()':
JITArithmetic32_64.cpp:(.text._ZN3JSC15JITSlowPathCall4callEv[JSC::JITSlowPathCall::call()]+0x240): undefined reference to `ctiVMHandleException'
/local/wkit/slavebuildbot_LOCAL/workspace_LOCAL/qt-linux-sh4-release/build/WebKitBuild/Release/Source/JavaScriptCore/release/libJavaScriptCore.a(JIT.o): In function `JSC::JITSlowPathCall::call() [clone .constprop.138]':
JIT.cpp:(.text+0x30ac): undefined reference to `ctiVMHandleException'
/local/wkit/slavebuildbot_LOCAL/workspace_LOCAL/qt-linux-sh4-release/build/WebKitBuild/Release/Source/JavaScriptCore/release/libJavaScriptCore.a(JITOpcodes32_64.o): In function `JSC::JIT::privateCompileCTINativeCall(JSC::VM*, long long (*)(JSC::ExecState*))':
JITOpcodes32_64.cpp:(.text+0x2194): undefined reference to `ctiVMHandleException'
/local/wkit/slavebuildbot_LOCAL/workspace_LOCAL/qt-linux-sh4-release/build/WebKitBuild/Release/Source/JavaScriptCore/release/libJavaScriptCore.a(JITOpcodes32_64.o): In function `JSC::JITSlowPathCall::call() [clone .constprop.99]':
JITOpcodes32_64.cpp:(.text+0x6aac): undefined reference to `ctiVMHandleException'
/local/wkit/slavebuildbot_LOCAL/workspace_LOCAL/qt-linux-sh4-release/build/WebKitBuild/Release/Source/JavaScriptCore/release/libJavaScriptCore.a(ThunkGenerators.o): In function `JSC::nativeForGenerator(JSC::VM*, JSC::CodeSpecializationKind)':
ThunkGenerators.cpp:(.text+0x139c): undefined reference to `ctiVMHandleException'
collect2: ld returned 1 exit status
Comment 1 Julien Brianceau 2013-08-16 00:20:33 PDT 
Created attachment 208886 [details]
sh4 build fix
Comment 2 Mark Lam 2013-08-16 00:29:37 PDT 
Comment on attachment 208886 [details]
sh4 build fix

View in context: https://bugs.webkit.org/attachment.cgi?id=208886&action=review

> Source/JavaScriptCore/jit/JITStubsSH4.h:120
> -    "lds r1, pr" "\n"
> -    "rts" "\n"
> +    "jmp @r1" "\n"

This part isn't due to r154156.  Why is this necessary?
Comment 3 Julien Brianceau 2013-08-16 00:31:46 PDT 
(In reply to comment #2)
> (From update of attachment 208886 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=208886&action=review
> 
> > Source/JavaScriptCore/jit/JITStubsSH4.h:120
> > -    "lds r1, pr" "\n"
> > -    "rts" "\n"
> > +    "jmp @r1" "\n"
> 
> This part isn't due to r154156.  Why is this necessary?

It saves one useless opcode, but you're right, this is not linked to r154156.

Do you want me to provide 2 separate patches ?
Comment 4 Julien Brianceau 2013-08-16 01:13:46 PDT 
Created attachment 208891 [details]
sh4 build fix

Build fix only
Comment 5 Julien Brianceau 2013-08-16 01:28:07 PDT 
Created attachment 208893 [details]
sh4 build fix (with description in ChangeLog)
Comment 6 WebKit Commit Bot 2013-08-16 02:24:46 PDT 
Comment on attachment 208893 [details]
sh4 build fix (with description in ChangeLog)

Clearing flags on attachment: 208893

Committed r154170: <http://trac.webkit.org/changeset/154170>
Comment 7 WebKit Commit Bot 2013-08-16 02:24:48 PDT 
All reviewed patches have been landed.  Closing bug.