Bug 119877 - DocumentLoader should be finished after convertMainResourceLoadToDownload
Summary: DocumentLoader should be finished after convertMainResourceLoadToDownload
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Page Loading (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mary Wu
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-08-15 22:56 PDT by Mary Wu
Modified: 2016-05-24 22:02 PDT (History)
4 users (show)

See Also:

Attachments
patch (1.92 KB, patch)
2013-08-15 23:03 PDT, Mary Wu 		beidson: review-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mary Wu 2013-08-15 22:56:15 PDT 
After convertMainResourceLoadToDownload(), we should wrap up current documentLoader. But if mainResource is cachedResource, mainResourceLoader doesn't exist, ResourceLoader::didFail() won't be hit, so the following DocumentLoader() dataReceived() will still cause the page loading. We add cancelMainResourceLoad() to make sure current page load finished gracefully.
Comment 1 Mary Wu 2013-08-15 23:03:22 PDT 
Created attachment 208882 [details]
patch
Comment 2 Darin Adler 2013-08-15 23:22:45 PDT 
Comment on attachment 208882 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=208882&action=review

> Source/WebCore/ChangeLog:13
> +        No new tests (OOPS!).

Why no regression test? Can we make one?
Comment 3 Brady Eidson 2016-05-24 22:02:28 PDT 
Comment on attachment 208882 [details]
patch

Assuming that patches for review since 2013 are stale, r-