RESOLVED FIXED 119865
Parent pointer and shadow root host pointer should not be shared 
https://bugs.webkit.org/show_bug.cgi?id=119865
Summary Parent pointer and shadow root host pointer should not be shared
Antti Koivisto
Reported 2013-08-15 14:24:33 PDT
Node::m_parentOrShadowHostNode is currently used both as the parent pointer for regular nodes and as the host pointer for ShadowRoots. This is confusing. It is also slow as it introduces a branch to all code paths that want to traverse element ancestors. It is especially important in selector matching.
Attachments
patch (29.33 KB, patch)
2013-08-15 14:44 PDT, Antti Koivisto 		kling: review+
webkit-ews: commit-queue-
DetailsFormatted DiffDiff
more release build friendly version (36.68 KB, patch)
2013-08-15 17:37 PDT, Antti Koivisto 		webkit-ews: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2013-08-15 14:44:39 PDT
Created attachment 208859 [details] patch
Early Warning System Bot
Comment 2 2013-08-15 15:03:07 PDT
Comment on attachment 208859 [details] patch Attachment 208859 [details] did not pass qt-ews (qt): Output: http://webkit-queues.appspot.com/results/1469316
Early Warning System Bot
Comment 3 2013-08-15 15:17:00 PDT
Comment on attachment 208859 [details] patch Attachment 208859 [details] did not pass qt-wk2-ews (qt-wk2): Output: http://webkit-queues.appspot.com/results/1462590
Build Bot
Comment 4 2013-08-15 15:31:42 PDT
Comment on attachment 208859 [details] patch Attachment 208859 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/1467370
Build Bot
Comment 5 2013-08-15 15:43:00 PDT
Comment on attachment 208859 [details] patch Attachment 208859 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/1470331
kov's GTK+ EWS bot
Comment 6 2013-08-15 15:53:32 PDT
Comment on attachment 208859 [details] patch Attachment 208859 [details] did not pass gtk-wk2-ews (gtk-wk2): Output: http://webkit-queues.appspot.com/results/1470336
Antti Koivisto
Comment 7 2013-08-15 17:37:25 PDT
Created attachment 208871 [details] more release build friendly version
Early Warning System Bot
Comment 8 2013-08-15 19:56:49 PDT
Comment on attachment 208871 [details] more release build friendly version Attachment 208871 [details] did not pass qt-wk2-ews (qt-wk2): Output: http://webkit-queues.appspot.com/results/1467431
Antti Koivisto
Comment 9 2013-08-15 23:33:01 PDT
http://trac.webkit.org/changeset/154165
Note You need to log in before you can comment on or make changes to this bug.