Bug 119864 - [CSS Shapes] Remove extraneous window.internals calls in layout tests
Summary: [CSS Shapes] Remove extraneous window.internals calls in layout tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Bear Travis
URL:
Keywords:
Depends on:
Blocks: 89256
  Show dependency tree / graph
 
Reported: 2013-08-15 14:23 PDT by Bear Travis
Modified: 2013-08-23 11:09 PDT (History)
2 users (show)

See Also:

Attachments
Initial patch (80.75 KB, patch)
2013-08-15 14:29 PDT, Bear Travis 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Bear Travis 2013-08-15 14:23:33 PDT 
With CSS Shapes enabled by default in nightly builds, we no longer have to explicitly enable CSS Shapes for each test.
Comment 1 Bear Travis 2013-08-15 14:29:13 PDT 
Created attachment 208856 [details]
Initial patch
Comment 2 Darin Adler 2013-08-15 18:27:11 PDT 
Comment on attachment 208856 [details]
Initial patch

Can we wait on this change until most platforms are shipping this feature by default? What’s the rush?
Comment 3 Bear Travis 2013-08-16 10:29:16 PDT 
This patch is just cleanup, as the window.internals.settings.setCSSShapesEnabled calls in these tests are unnecessary. The platforms that expose setCSSShapesEnabled now have shapes enabled by default, and the platforms that don't exclude these test directories. window.internals.settings.setCSSShapesEnabled(true) is basically a no-op.

These tests would fail with or without this patch in builds that do not compile with ENABLE_CSS_SHAPES flag set.
Comment 4 Alexandru Chiculita 2013-08-23 10:46:49 PDT 
Comment on attachment 208856 [details]
Initial patch

r=me
Comment 5 WebKit Commit Bot 2013-08-23 11:09:29 PDT 
Comment on attachment 208856 [details]
Initial patch

Clearing flags on attachment: 208856

Committed r154500: <http://trac.webkit.org/changeset/154500>
Comment 6 WebKit Commit Bot 2013-08-23 11:09:31 PDT 
All reviewed patches have been landed.  Closing bug.