RESOLVED FIXED 119827
Allow primary plug-in detection to run more than once if necessary 
https://bugs.webkit.org/show_bug.cgi?id=119827
Summary Allow primary plug-in detection to run more than once if necessary
Dean Jackson
Reported 2013-08-14 17:01:34 PDT
We occasionally see cases where the primary plug-in detection runs before the plugins have been added to the page, especially if they do so in response to a load event. Tweak the algorithm so that it can run an arbitrary number of times if it fails.
Attachments
Patch (5.73 KB, patch)
2013-08-14 17:07 PDT, Dean Jackson 		thorton: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dean Jackson
Comment 1 2013-08-14 17:02:15 PDT
<rdar://problem/14680740>
Radar WebKit Bug Importer
Comment 2 2013-08-14 17:02:49 PDT
<rdar://problem/14741980>
Dean Jackson
Comment 3 2013-08-14 17:07:33 PDT
Created attachment 208775 [details] Patch
Tim Horton
Comment 4 2013-08-14 17:32:17 PDT
Comment on attachment 208775 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=208775&action=review > Source/WebKit2/WebProcess/WebPage/WebPage.h:863 > + bool m_hasSeenPlugin; I'm pretty sure you need to reset this more often than you do.
Tim Horton
Comment 5 2013-08-14 17:35:58 PDT
Comment on attachment 208775 [details] Patch r=me with the change you mentioned on IRC to address the above comment
Dean Jackson
Comment 6 2013-08-14 17:40:08 PDT
Change on irc was to add this to resetPrimarySnapshottedPlugIn m_numberOfPrimarySnapshotDetectionAttempts = 0; m_hasSeenPlugin = false;
Dean Jackson
Comment 7 2013-08-14 17:44:03 PDT
Committed r154085: <http://trac.webkit.org/changeset/154085>
Note You need to log in before you can comment on or make changes to this bug.