Bug 119827 - Allow primary plug-in detection to run more than once if necessary
Summary: Allow primary plug-in detection to run more than once if necessary
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Plug-ins (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dean Jackson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2013-08-14 17:01 PDT by Dean Jackson
Modified: 2013-08-14 17:44 PDT (History)
2 users (show)

See Also:

Attachments
Patch (5.73 KB, patch)
2013-08-14 17:07 PDT, Dean Jackson 		thorton: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dean Jackson 2013-08-14 17:01:34 PDT 
We occasionally see cases where the primary plug-in detection runs before the plugins have been added to the page, especially if they do so in response to a load event. Tweak the algorithm so that it can run an arbitrary number of times if it fails.
Comment 1 Dean Jackson 2013-08-14 17:02:15 PDT 
<rdar://problem/14680740>
Comment 2 Radar WebKit Bug Importer 2013-08-14 17:02:49 PDT 
<rdar://problem/14741980>
Comment 3 Dean Jackson 2013-08-14 17:07:33 PDT 
Created attachment 208775 [details]
Patch
Comment 4 Tim Horton 2013-08-14 17:32:17 PDT 
Comment on attachment 208775 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=208775&action=review

> Source/WebKit2/WebProcess/WebPage/WebPage.h:863
> +    bool m_hasSeenPlugin;

I'm pretty sure you need to reset this more often than you do.
Comment 5 Tim Horton 2013-08-14 17:35:58 PDT 
Comment on attachment 208775 [details]
Patch

r=me with the change you mentioned on IRC to address the above comment
Comment 6 Dean Jackson 2013-08-14 17:40:08 PDT 
Change on irc was to add this to resetPrimarySnapshottedPlugIn

    m_numberOfPrimarySnapshotDetectionAttempts = 0;
    m_hasSeenPlugin = false;
Comment 7 Dean Jackson 2013-08-14 17:44:03 PDT 
Committed r154085: <http://trac.webkit.org/changeset/154085>