WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
119824
AX: WKView does not become first responder when the voiceover cursor lands on it
https://bugs.webkit.org/show_bug.cgi?id=119824
Summary
AX: WKView does not become first responder when the voiceover cursor lands on it
chris fleizach
Reported
2013-08-14 16:07:30 PDT
* SUMMARY WKView does not become first responder when the voiceover cursor lands on it * STEPS TO REPRODUCE 1. Open Safari or Mail and enable voiceover 2. Navigate voiceover cursor to the web view * RESULTS Expected: The WKView should become the first responder Actual: The WKView does not become the first responder
Attachments
patch
(2.81 KB, patch)
2013-08-14 16:29 PDT
,
chris fleizach
no flags
Details
Formatted Diff
Diff
patch
(2.67 KB, patch)
2013-08-14 16:31 PDT
,
chris fleizach
thorton
: review+
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
chris fleizach
Comment 1
2013-08-14 16:07:37 PDT
rdar://14719187
Lucas Forschler
Comment 2
2013-08-14 16:12:03 PDT
<
rdar://problem/14719187
>
chris fleizach
Comment 3
2013-08-14 16:29:48 PDT
Created
attachment 208770
[details]
patch
chris fleizach
Comment 4
2013-08-14 16:31:53 PDT
Created
attachment 208771
[details]
patch
Tim Horton
Comment 5
2013-08-14 16:35:09 PDT
Comment on
attachment 208771
[details]
patch View in context:
https://bugs.webkit.org/attachment.cgi?id=208771&action=review
> Source/WebCore/accessibility/AccessibilityScrollView.cpp:106 > + return webArea->setFocused(focused);
why return?
chris fleizach
Comment 6
2013-08-14 16:41:22 PDT
Comment on
attachment 208771
[details]
patch View in context:
https://bugs.webkit.org/attachment.cgi?id=208771&action=review
>> Source/WebCore/accessibility/AccessibilityScrollView.cpp:106 >> + return webArea->setFocused(focused); > > why return?
ah good point. no need. will remove
Tim Horton
Comment 7
2013-08-14 16:41:38 PDT
Also, can we test this?
chris fleizach
Comment 8
2013-08-14 16:45:32 PDT
(In reply to
comment #7
)
> Also, can we test this?
I don't think there's an easy way to test this because focus has to be outside the web content and then highlight scroll view content and then we need to confirm that WKView is the first responder.
chris fleizach
Comment 9
2013-08-14 16:59:11 PDT
http://trac.webkit.org/changeset/154083
Darin Adler
Comment 10
2013-08-15 12:23:18 PDT
Comment on
attachment 208771
[details]
patch View in context:
https://bugs.webkit.org/attachment.cgi?id=208771&action=review
> Source/WebCore/accessibility/AccessibilityScrollView.cpp:93 > + if (AccessibilityObject* webArea = webAreaObject()) > + return webArea->canSetFocusAttribute(); > + return false;
I think small functions like this read better as: AccessibilityObject* webArea = webAreaObject(); return webArea && webArea->canSetFocusAttribute();
> Source/WebCore/accessibility/AccessibilityScrollView.h:69 > + virtual void setFocused(bool); > + virtual bool canSetFocusAttribute() const; > + virtual bool isFocused() const;
Should have OVERRIDE on all these.
chris fleizach
Comment 11
2013-08-15 12:26:53 PDT
(In reply to
comment #10
)
> (From update of
attachment 208771
[details]
) > View in context:
https://bugs.webkit.org/attachment.cgi?id=208771&action=review
> > > Source/WebCore/accessibility/AccessibilityScrollView.cpp:93 > > + if (AccessibilityObject* webArea = webAreaObject()) > > + return webArea->canSetFocusAttribute(); > > + return false; > > I think small functions like this read better as: > > AccessibilityObject* webArea = webAreaObject(); > return webArea && webArea->canSetFocusAttribute(); > > > Source/WebCore/accessibility/AccessibilityScrollView.h:69 > > + virtual void setFocused(bool); > > + virtual bool canSetFocusAttribute() const; > > + virtual bool isFocused() const; > > Should have OVERRIDE on all these.
Thanks. Will fix these right away
chris fleizach
Comment 12
2013-08-15 12:59:14 PDT
(In reply to
comment #11
)
> (In reply to
comment #10
) > > (From update of
attachment 208771
[details]
[details]) > > View in context:
https://bugs.webkit.org/attachment.cgi?id=208771&action=review
> > > > > Source/WebCore/accessibility/AccessibilityScrollView.cpp:93 > > > + if (AccessibilityObject* webArea = webAreaObject()) > > > + return webArea->canSetFocusAttribute(); > > > + return false; > > > > I think small functions like this read better as: > > > > AccessibilityObject* webArea = webAreaObject(); > > return webArea && webArea->canSetFocusAttribute(); > > > > > Source/WebCore/accessibility/AccessibilityScrollView.h:69 > > > + virtual void setFocused(bool); > > > + virtual bool canSetFocusAttribute() const; > > > + virtual bool isFocused() const; > > > > Should have OVERRIDE on all these. > > Thanks. Will fix these right away
http://trac.webkit.org/changeset/154123
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug