Bug 119821 - AX: platform/mac/accessibility/role-subrole-roledescription.html is failing
Summary: AX: platform/mac/accessibility/role-subrole-roledescription.html is failing
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: chris fleizach
Keywords: InRadar
: 119873 (view as bug list)
Depends on:
Reported: 2013-08-14 15:41 PDT by chris fleizach
Modified: 2013-08-15 17:44 PDT (History)
11 users (show)

See Also:

Updated layout test. (2.25 KB, patch)
2013-08-15 15:32 PDT, Samuel White
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description chris fleizach 2013-08-14 15:41:32 PDT
After https://bugs.webkit.org/show_bug.cgi?id=119706 landed this test started to fail
Comment 1 Radar WebKit Bug Importer 2013-08-14 15:41:53 PDT
Comment 2 Alexey Proskuryakov 2013-08-15 10:22:38 PDT
Who is going to look into this? Looks like this is still making bots red.
Comment 3 Samuel White 2013-08-15 11:18:50 PDT
I'm investigating this now with help from Chris.
Comment 4 Samuel White 2013-08-15 14:49:31 PDT
accessibilityController.accessibleElementById is returning an AccessibilityUIElement object in every case. This means that if you do say:


you will get an object back (a junk object, but still an object). So our test:

axElement = accessibilityController.accessibleElementById(el.id);
       if (axElement) {

Is invalid because it will always pass. So in the math case we were getting back a junk element from accessibleElementById and comparing that axElements role (which returned nothing) to element.getAttribute('data-role') (which was set to nothing) so we passed.

So the fix for this issue is to simply update our layout test. I'll poke around the other accessibility layout tests and file a bug if any others have invalid axElement condition checks like above.
Comment 5 Samuel White 2013-08-15 15:32:53 PDT
Created attachment 208865 [details]
Updated layout test.

This updates our layout test to account for id working correctly on the math element.
Comment 6 WebKit Commit Bot 2013-08-15 16:18:03 PDT
Comment on attachment 208865 [details]
Updated layout test.

Clearing flags on attachment: 208865

Committed r154148: <http://trac.webkit.org/changeset/154148>
Comment 7 WebKit Commit Bot 2013-08-15 16:18:07 PDT
All reviewed patches have been landed.  Closing bug.
Comment 8 chris fleizach 2013-08-15 16:27:38 PDT
*** Bug 119873 has been marked as a duplicate of this bug. ***
Comment 9 Alexey Proskuryakov 2013-08-15 17:44:42 PDT
Thank you for tackling this!