After https://bugs.webkit.org/show_bug.cgi?id=119706 landed this test started to fail
<rdar://problem/14740959>
Who is going to look into this? Looks like this is still making bots red.
I'm investigating this now with help from Chris.
accessibilityController.accessibleElementById is returning an AccessibilityUIElement object in every case. This means that if you do say: accessibilityController.accessibleElementById('fdsafdsafdsa') you will get an object back (a junk object, but still an object). So our test: axElement = accessibilityController.accessibleElementById(el.id); if (axElement) { Is invalid because it will always pass. So in the math case we were getting back a junk element from accessibleElementById and comparing that axElements role (which returned nothing) to element.getAttribute('data-role') (which was set to nothing) so we passed. So the fix for this issue is to simply update our layout test. I'll poke around the other accessibility layout tests and file a bug if any others have invalid axElement condition checks like above.
Created attachment 208865 [details] Updated layout test. This updates our layout test to account for id working correctly on the math element.
Comment on attachment 208865 [details] Updated layout test. Clearing flags on attachment: 208865 Committed r154148: <http://trac.webkit.org/changeset/154148>
All reviewed patches have been landed. Closing bug.
*** Bug 119873 has been marked as a duplicate of this bug. ***
Thank you for tackling this!