FloatingObject m_paginationStrut should be LayoutUnit

[Bem Jones-Bey]

It is a vertical offset, and it will be much clearer if the type is correct.

[Bem Jones-Bey]

Created attachment 223293 [details]
Patch

[Andreas Kling]

Comment on attachment 223293 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=223293&action=review

r=me

> Source/WebCore/ChangeLog:13
> +        Also, stop copying the originatingLine in FloatingObject::unsafeClone
> +        because that allows a FloatingObject to point to a line for a renderer
> +        that it doesn't belong to.

I would do this in a separate change.

[Bem Jones-Bey]

(In reply to comment #2)
> (From update of attachment 223293 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=223293&action=review
> 
> r=me
> 
> > Source/WebCore/ChangeLog:13
> > +        Also, stop copying the originatingLine in FloatingObject::unsafeClone
> > +        because that allows a FloatingObject to point to a line for a renderer
> > +        that it doesn't belong to.
> 
> I would do this in a separate change.

Thanks! I'll pull that out into a different patch.

[Bem Jones-Bey]

Created attachment 223465 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 223465 [details]
Patch for landing

Clearing flags on attachment: 223465

Committed r163631: <http://trac.webkit.org/changeset/163631>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.