Bug 119798 - ANGLE doesn't build with bison 3.0
: ANGLE doesn't build with bison 3.0
Product: WebKit
Classification: Unclassified
Component: ANGLE
: 528+ (Nightly build)
: Unspecified Unspecified
: P2 Normal
Assigned To: Allan Sandfeld Jensen
Depends on:
  Show dependency treegraph
Reported: 2013-08-14 07:42 PDT by Allan Sandfeld Jensen
Modified: 2013-08-15 10:58 PDT (History)
10 users (show)

See Also:

Patch (2.44 KB, patch)
2013-08-14 08:04 PDT, Allan Sandfeld Jensen
no flags Details | Formatted Diff | Diff
Patch (1.85 KB, patch)
2013-08-14 08:43 PDT, Allan Sandfeld Jensen
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Allan Sandfeld Jensen 2013-08-14 07:42:48 PDT
When using bison 3.0 we have problems building ANGLE. I believe the easiest solution is to stop generating our own files and use those pregenerated in WebKit.
Comment 1 Allan Sandfeld Jensen 2013-08-14 07:44:33 PDT
Qt bug tracked as https://bugreports.qt-project.org/browse/QTBUG-32913
Comment 2 Allan Sandfeld Jensen 2013-08-14 08:04:07 PDT
Created attachment 208725 [details]
Comment 3 Allan Sandfeld Jensen 2013-08-14 08:43:29 PDT
Created attachment 208731 [details]

Just fix the parser file to be compatible with bison 3
Comment 4 Raphael Kubo da Costa (:rakuco) 2013-08-15 04:27:43 PDT
For the record, carewolf has also submitted this upstream: <https://code.google.com/p/angleproject/issues/detail?id=462>.
Comment 5 Alex Christensen 2013-08-15 10:20:21 PDT
Looks good to me.  I tried this on Mac, and it works with Bison 2.3.  This is suggested as a patch upstream at https://code.google.com/p/angleproject/issues/detail?id=462 so hopefully we'll merge this change in with a future ANGLE update anyway.
Comment 6 Alex Christensen 2013-08-15 10:37:12 PDT
By the way, this would change the generated files a little, but there are no functional changes and we're trying to remove them from the repository anyways, so don't worry about that.
Comment 7 WebKit Commit Bot 2013-08-15 10:58:34 PDT
Comment on attachment 208731 [details]

Clearing flags on attachment: 208731

Committed r154109: <http://trac.webkit.org/changeset/154109>
Comment 8 WebKit Commit Bot 2013-08-15 10:58:36 PDT
All reviewed patches have been landed.  Closing bug.