Bug 119798 - ANGLE doesn't build with bison 3.0
: ANGLE doesn't build with bison 3.0
Status: RESOLVED FIXED
: WebKit
ANGLE
: 528+ (Nightly build)
: Unspecified Unspecified
: P2 Normal
Assigned To:
:
:
:
:
  Show dependency treegraph
 
Reported: 2013-08-14 07:42 PST by
Modified: 2013-08-15 10:58 PST (History)


Attachments
Patch (2.44 KB, patch)
2013-08-14 08:04 PST, Allan Sandfeld Jensen
no flags Review Patch | Details | Formatted Diff | Diff
Patch (1.85 KB, patch)
2013-08-14 08:43 PST, Allan Sandfeld Jensen
no flags Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2013-08-14 07:42:48 PST
When using bison 3.0 we have problems building ANGLE. I believe the easiest solution is to stop generating our own files and use those pregenerated in WebKit.
------- Comment #1 From 2013-08-14 07:44:33 PST -------
Qt bug tracked as https://bugreports.qt-project.org/browse/QTBUG-32913
------- Comment #2 From 2013-08-14 08:04:07 PST -------
Created an attachment (id=208725) [details]
Patch
------- Comment #3 From 2013-08-14 08:43:29 PST -------
Created an attachment (id=208731) [details]
Patch

Just fix the parser file to be compatible with bison 3
------- Comment #4 From 2013-08-15 04:27:43 PST -------
For the record, carewolf has also submitted this upstream: <https://code.google.com/p/angleproject/issues/detail?id=462>.
------- Comment #5 From 2013-08-15 10:20:21 PST -------
Looks good to me.  I tried this on Mac, and it works with Bison 2.3.  This is suggested as a patch upstream at https://code.google.com/p/angleproject/issues/detail?id=462 so hopefully we'll merge this change in with a future ANGLE update anyway.
------- Comment #6 From 2013-08-15 10:37:12 PST -------
By the way, this would change the generated files a little, but there are no functional changes and we're trying to remove them from the repository anyways, so don't worry about that.
------- Comment #7 From 2013-08-15 10:58:34 PST -------
(From update of attachment 208731 [details])
Clearing flags on attachment: 208731

Committed r154109: <http://trac.webkit.org/changeset/154109>
------- Comment #8 From 2013-08-15 10:58:36 PST -------
All reviewed patches have been landed.  Closing bug.