Bug 119787 – Add toSVGClipPathElement(), and use it

• Status: RESOLVED
• Resolution: FIXED
• Component: SVG

[Gyuyoung Kim]

As a step to clean-up static_cast<SVGXXX>, static_cast<SVGClipPathElement*> also can be changed with toSVGClipPathElement(). As minor clean-up, this cl changes to use toSVGSVGElement() instead of static_cast<SVGSVGElement*>.

Blink merge from https://src.chromium.org/viewvc/blink?view=rev&revision=156069

[Gyuyoung Kim]

Created attachment 208704 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 208704 [details]
Patch

Rejecting attachment 208704 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-03', 'build', '--no-clean', '--no-update', '--build-style=release', '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
.sh"
(1 failure)

Failed to run "['Tools/Scripts/build-webkit', '--release']" exit_code: 65

make: *** wait: No child processes.  Stop.
make: *** Waiting for unfinished jobs....
make: *** wait: No child processes.  Stop.
Command /bin/sh failed with exit code 2


** BUILD FAILED **


The following build commands failed:
	PhaseScriptExecution "Generate Derived Sources" "/Volumes/Data/EWS/WebKit/WebKitBuild/WebKit2.build/Release/Derived Sources.build/Script-C0CE72841247E66800BC0EC4.sh"
(1 failure)

Full output: http://webkit-queues.appspot.com/results/1451799

[Dirk Schulze]

Could you land this patch please? Thanks.

[WebKit Commit Bot]

Comment on attachment 208704 [details]
Patch

Rejecting attachment 208704 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 208704, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
- saving rejects to file Source/WebCore/rendering/svg/RenderSVGResourceClipper.h.rej
patching file Source/WebCore/svg/SVGClipPathElement.h
Hunk #1 succeeded at 25 (offset -1 lines).
Hunk #2 succeeded at 59 with fuzz 2 (offset 2 lines).
patching file Source/WebCore/svg/SVGSVGElement.cpp
Hunk #1 succeeded at 696 with fuzz 1 (offset -34 lines).

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Ryosuke Niwa']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.appspot.com/results/6241939540148224

[Dirk Schulze]

Ok, this either landed already or was fixed by someone else.

[Gyuyoung Kim]

(In reply to comment #5)
> Ok, this either landed already or was fixed by someone else.

Oops, I forget to land this patch :(. Right. this patch isn't needed anymore.