Bug 119782 - [EFL] fast/forms/search-styled.html is failing
Summary: [EFL] fast/forms/search-styled.html is failing
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-08-13 21:19 PDT by Ryuan Choi
Modified: 2017-03-11 10:32 PST (History)
7 users (show)

See Also:


Attachments
Patch (9.17 KB, patch)
2013-10-26 06:49 PDT, Santosh Mahto
kling: review-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryuan Choi 2013-08-13 21:19:18 PDT
fast/forms/search-styled.html requires apple image but Efl port does draw it.
Comment 1 Santosh Mahto 2013-10-26 06:49:48 PDT
Created attachment 215248 [details]
Patch
Comment 2 Santosh Mahto 2013-10-26 07:50:24 PDT
After changeset 157443 , search field now respect the background properties.
So now the .png and .txt is updated for new behavior.

.png --> is the actual display for current search-styled.html.Although it looks misaligned. see chrome behavior.
Comment 3 Ryuan Choi 2013-10-27 16:39:47 PDT
Comment on attachment 215248 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=215248&action=review

> LayoutTests/ChangeLog:9
> +        * platform/efl/fast/forms/search-styled-expected.png: Added.

Is it correct result?

It looks different from mac or gtk.
Comment 4 Gyuyoung Kim 2013-10-27 17:58:05 PDT
Comment on attachment 215248 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=215248&action=review

>> LayoutTests/ChangeLog:9
>> +        * platform/efl/fast/forms/search-styled-expected.png: Added.
> 
> Is it correct result?
> 
> It looks different from mac or gtk.

Looks wrong result.
Comment 5 Santosh Mahto 2013-10-27 22:56:47 PDT
(In reply to comment #4)
> (From update of attachment 215248 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=215248&action=review
> 
> >> LayoutTests/ChangeLog:9
> >> +        * platform/efl/fast/forms/search-styled-expected.png: Added.
> > 
> > Is it correct result?
> > 
> > It looks different from mac or gtk.
> 
> Looks wrong result.

Its right.
After changeset 157443 T(In reply to comment #3)
> (From update of attachment 215248 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=215248&action=review
> 
> > LayoutTests/ChangeLog:9
> > +        * platform/efl/fast/forms/search-styled-expected.png: Added.
> 
> Is it correct result?
> 
> It looks different from mac or gtk.

 mac or gtk also need to rebaselined. After changeset 157443 search background property is considered.
The .png looks misaligned becasue .html is written in that way.
If you have mac/gtk build then you can confirm by loading this page. Athough chrome has already same display.

So .png is the correct display for testcase even though it looks misaligned.
so its right,
Comment 6 Gyuyoung Kim 2013-12-25 18:49:03 PST
Comment on attachment 215248 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=215248&action=review

>>>>> LayoutTests/ChangeLog:9
>>>>> +        * platform/efl/fast/forms/search-styled-expected.png: Added.
>>>> 
>>>> Is it correct result?
>>>> 
>>>> It looks different from mac or gtk.
>>> 
>>> Looks wrong result.
>> 
>> Its right.
>> After changeset 157443 T(In reply to comment #3)
> 
> mac or gtk also need to rebaselined. After changeset 157443 search background property is considered.
> The .png looks misaligned becasue .html is written in that way.
> If you have mac/gtk build then you can confirm by loading this page. Athough chrome has already same display.
> 
> So .png is the correct display for testcase even though it looks misaligned.
> so its right,

I still think that we need to have reasonable image result. Your expected image looks still wrong result.
Comment 7 Andreas Kling 2014-02-05 17:48:30 PST
Comment on attachment 215248 [details]
Patch

The new result here is obviously incorrect and does not match the mac port.
Comment 8 Michael Catanzaro 2017-03-11 10:32:51 PST
Closing this bug because the EFL port has been removed from trunk.

If you feel this bug applies to a different upstream WebKit port and was closed in error, please either update the title and reopen the bug, or leave a comment to request this.