RESOLVED FIXED 119778
Add Canvas protocol observer 
https://bugs.webkit.org/show_bug.cgi?id=119778
Summary Add Canvas protocol observer
Dean Jackson
Reported 2013-08-13 17:16:58 PDT
Now that we're enabling Canvas profiling, we need a canvas observer to receive the events sent from the backend.
Attachments
Patch (4.74 KB, patch)
2013-08-13 17:25 PDT, Dean Jackson 		joepeck: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2013-08-13 17:17:13 PDT
<rdar://problem/14730691>
Dean Jackson
Comment 2 2013-08-13 17:25:21 PDT
Created attachment 208693 [details] Patch
Joseph Pecoraro
Comment 3 2013-08-13 17:36:02 PDT
Comment on attachment 208693 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=208693&action=review r=me, with 1 comment > Source/WebInspectorUI/UserInterface/Main.js:41 > + InspectorBackend.registerCanvasDispatcher(new WebInspector.CanvasObserver); InspectorBackend.registerCanvasDispatcher did not exist in iOS 6. iOS 6 devices load the UserInterface/Legacy/6.0/InspectorBackendCommands.js file instead of the UserInterface/InspectorBackendCommands.js in LoadInspectorBackendCommands.js. So the lack of that function existing will mean that this would be an uncaught exception. You should do this at the bottom like the LayerTreeDispatcher. if (InspectorBackend.registerCanvasDispatcher) InspectorBackend.registerCanvasDispatcher(new WebInspector.CanvasObserver);
Dean Jackson
Comment 4 2013-08-13 18:03:34 PDT
Committed r154034: <http://trac.webkit.org/changeset/154034>
Note You need to log in before you can comment on or make changes to this bug.