RESOLVED FIXED119769
Stop using DEFINE_STATIC_LOCAL with RefPtr 
https://bugs.webkit.org/show_bug.cgi?id=119769
Summary Stop using DEFINE_STATIC_LOCAL with RefPtr
Anders Carlsson
Reported 2013-08-13 14:25:43 PDT
Stop using DEFINE_STATIC_LOCAL with RefPtr
Attachments
Patch (13.79 KB, patch)
2013-08-13 14:26 PDT, Anders Carlsson 		kling: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2013-08-13 14:26:44 PDT
Created attachment 208677 [details] Patch
Andreas Kling
Comment 2 2013-08-13 14:35:03 PDT
Comment on attachment 208677 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=208677&action=review r=me, but... It'd be nice to make the methods that never return null return references instead of pointers. > Source/WebCore/editing/EditingStyle.cpp:1431 > - DEFINE_STATIC_LOCAL(RefPtr<CSSPrimitiveValue>, underline, (CSSPrimitiveValue::createIdentifier(CSSValueUnderline))); > - DEFINE_STATIC_LOCAL(RefPtr<CSSPrimitiveValue>, lineThrough, (CSSPrimitiveValue::createIdentifier(CSSValueLineThrough))); > + static CSSPrimitiveValue* underline = CSSPrimitiveValue::createIdentifier(CSSValueUnderline).leakRef(); > + static CSSPrimitiveValue* lineThrough = CSSPrimitiveValue::createIdentifier(CSSValueLineThrough).leakRef(); This is silly, we should just use cssValuePool().createIdentifierValue(CSSValueUnderline / CSSValueLineThrough) for these instead. Save even more memory :)
Anders Carlsson
Comment 3 2013-08-13 14:46:52 PDT
Committed r154023: <http://trac.webkit.org/changeset/154023>
Note You need to log in before you can comment on or make changes to this bug.