Bug 119752 - [Mac] Remove "legacy" media UI
Summary: [Mac] Remove "legacy" media UI
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Carlson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2013-08-13 08:47 PDT by Eric Carlson
Modified: 2013-08-15 11:48 PDT (History)
5 users (show)

See Also:


Attachments
Proposed patch (1.35 MB, patch)
2013-08-15 11:41 PDT, Eric Carlson
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Carlson 2013-08-13 08:47:27 PDT
The "legacy" media UI hasn't been used in some time, it should be removed.
Comment 1 Eric Carlson 2013-08-13 08:47:45 PDT
<rdar://problem/14724023>
Comment 2 Eric Carlson 2013-08-15 11:41:07 PDT
Created attachment 208826 [details]
Proposed patch
Comment 3 Jer Noble 2013-08-15 11:42:06 PDT
Comment on attachment 208826 [details]
Proposed patch

r=me.
Comment 4 WebKit Commit Bot 2013-08-15 11:43:52 PDT
Attachment 208826 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/WebCore.exp.in', u'Source/WebCore/platform/mac/WebCoreSystemInterface.h', u'Source/WebCore/platform/mac/WebCoreSystemInterface.mm', u'Source/WebCore/rendering/RenderThemeMac.h', u'Source/WebCore/rendering/RenderThemeMac.mm', u'Source/WebKit/mac/ChangeLog', u'Source/WebKit/mac/WebCoreSupport/WebSystemInterface.mm', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/WebProcess/WebCoreSupport/mac/WebSystemInterface.mm', u'WebKitLibraries/ChangeLog', u'WebKitLibraries/WebKitSystemInterface.h', u'WebKitLibraries/libWebKitSystemInterfaceLion.a', u'WebKitLibraries/libWebKitSystemInterfaceMountainLion.a']" exit_code: 1
WebKitLibraries/WebKitSystemInterface.h:306:  The parameter name "point" adds no information, so it should be removed.  [readability/parameter_name] [5]
WebKitLibraries/WebKitSystemInterface.h:308:  The parameter name "context" adds no information, so it should be removed.  [readability/parameter_name] [5]
WebKitLibraries/WebKitSystemInterface.h:308:  The parameter name "rect" adds no information, so it should be removed.  [readability/parameter_name] [5]
WebKitLibraries/WebKitSystemInterface.h:309:  The parameter name "context" adds no information, so it should be removed.  [readability/parameter_name] [5]
WebKitLibraries/WebKitSystemInterface.h:309:  The parameter name "rect" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 5 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Eric Carlson 2013-08-15 11:48:12 PDT
Committed r154112 - http://trac.webkit.org/changeset/154112.