This is required for the javascript injection and isolated worlds API. See https://lists.webkit.org/pipermail/webkit-gtk/2013-August/001535.html.
Created attachment 208624 [details] Patch
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment on attachment 208624 [details] Patch Attachment 208624 [details] did not pass gtk-ews (gtk): Output: http://webkit-queues.appspot.com/results/1452440
Created attachment 208634 [details] Updated patch I forgot to git add some new files
Created attachment 208638 [details] Another update Sorry, I forgot to git add two more files.
Comment on attachment 208638 [details] Another update View in context: https://bugs.webkit.org/attachment.cgi?id=208638&action=review Changes (informally) look awesome to me > Source/WebKit2/UIProcess/API/gtk/docs/webkit2gtk-sections.txt:1064 > +webkit_frame_get_javascript_global_context nit: should we have these properly sorted? > Source/WebKit2/WebProcess/InjectedBundle/API/gtk/WebKitWebPage.cpp:305 > + kWKBundlePageLoaderClientCurrentVersion, wow this probably deserved a separate fix :), good catch
Comment on attachment 208638 [details] Another update View in context: https://bugs.webkit.org/attachment.cgi?id=208638&action=review LGTM, r=me, just need to get a wk2 owner to approve, I guess. >> Source/WebKit2/WebProcess/InjectedBundle/API/gtk/WebKitWebPage.cpp:305 >> + kWKBundlePageLoaderClientCurrentVersion, > > wow this probably deserved a separate fix :), good catch Indeed, r=me for landing this separately!
(In reply to comment #7) > (From update of attachment 208638 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=208638&action=review > > LGTM, r=me, just need to get a wk2 owner to approve, I guess. > > >> Source/WebKit2/WebProcess/InjectedBundle/API/gtk/WebKitWebPage.cpp:305 > >> + kWKBundlePageLoaderClientCurrentVersion, > > > > wow this probably deserved a separate fix :), good catch > > Indeed, r=me for landing this separately! Fixed in http://trac.webkit.org/changeset/154474
Comment on attachment 208638 [details] Another update View in context: https://bugs.webkit.org/attachment.cgi?id=208638&action=review > Source/WebKit2/WebProcess/InjectedBundle/API/gtk/WebKitWebPage.cpp:74 > + DEFINE_STATIC_LOCAL(WebFrameMap, map, ()); Can use NeverDestroyed here!
Committed r154540: <http://trac.webkit.org/changeset/154540>
This has caused 6 unit tests to fail: http://build.webkit.org/builders/Apple%20MountainLion%20Debug%20WK2%20%28Tests%29/builds/11911/steps/run-api-tests/logs/stdio
(In reply to comment #11) > This has caused 6 unit tests to fail: > http://build.webkit.org/builders/Apple%20MountainLion%20Debug%20WK2%20%28Tests%29/builds/11911/steps/run-api-tests/logs/stdio Fix is up for review in bug #120268.