Bug 119739 - Precision updates in WebAudio
Summary: Precision updates in WebAudio
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Audio (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-08-13 03:23 PDT by Praveen Jadhav
Modified: 2013-09-05 06:24 PDT (History)
10 users (show)

See Also:


Attachments
Patch (8.27 KB, patch)
2013-08-13 03:32 PDT, Praveen Jadhav
no flags Details | Formatted Diff | Diff
Patch (7.27 KB, patch)
2013-08-13 04:09 PDT, Praveen Jadhav
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Praveen Jadhav 2013-08-13 03:23:40 PDT
Attributes minDecibels, maxDecibels and smoothingTimeConstant in AnalyserNode and currentTime in AudioContext should be of type double.
Comment 1 Praveen Jadhav 2013-08-13 03:32:49 PDT
Created attachment 208614 [details]
Patch

Patch includes one minor optimization in GStreamer porting file WebKitWebAudioSourceGStreamer.cpp
Comment 2 Chris Dumez 2013-08-13 03:45:57 PDT
Comment on attachment 208614 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=208614&action=review

> Source/WebCore/ChangeLog:7
> +

Missing changelog

> Source/WebCore/platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:-246
> -    for (unsigned channelIndex = 0; channelIndex < priv->bus->numberOfChannels(); channelIndex++) {

Looks unrelated?
Comment 3 Philippe Normand 2013-08-13 03:50:00 PDT
Comment on attachment 208614 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=208614&action=review

>> Source/WebCore/platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:-246
>> -    for (unsigned channelIndex = 0; channelIndex < priv->bus->numberOfChannels(); channelIndex++) {
> 
> Looks unrelated?

This is unrelated, and how is this an optimization? This is how the GLib docs advize on how to fill a GSList. It's not the first time people try to optimize this code :)
Comment 4 Chris Dumez 2013-08-13 03:53:50 PDT
Comment on attachment 208614 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=208614&action=review

>>> Source/WebCore/platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:-246
>>> -    for (unsigned channelIndex = 0; channelIndex < priv->bus->numberOfChannels(); channelIndex++) {
>> 
>> Looks unrelated?
> 
> This is unrelated, and how is this an optimization? This is how the GLib docs advize on how to fill a GSList. It's not the first time people try to optimize this code :)

Well, it avoids a call to g_slist_reverse() so it can only be faster IMHO. That said, this is a micro-optimization considering the number of channels (and thus the size of the list).
In any case, this should not be in this patch.
Comment 5 Praveen Jadhav 2013-08-13 03:57:10 PDT
(In reply to comment #2)
> (From update of attachment 208614 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=208614&action=review
> 
> > Source/WebCore/ChangeLog:7
> > +
> 
> Missing changelog

oh, I missed. Will update this shortly.

> 
> > Source/WebCore/platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:-246
> > -    for (unsigned channelIndex = 0; channelIndex < priv->bus->numberOfChannels(); channelIndex++) {
> 
> Looks unrelated?

Its a minor change to avoid calling g_slist_reverse() API. So, thought of including this in the same bug. Will raise a new bug for this patch.
Comment 6 Praveen Jadhav 2013-08-13 04:09:35 PDT
Created attachment 208616 [details]
Patch

Patch updated as per the comments.
Comment 7 WebKit Commit Bot 2013-09-05 06:24:50 PDT
Comment on attachment 208616 [details]
Patch

Clearing flags on attachment: 208616

Committed r155112: <http://trac.webkit.org/changeset/155112>
Comment 8 WebKit Commit Bot 2013-09-05 06:24:54 PDT
All reviewed patches have been landed.  Closing bug.