Consider merging https://chromium.googlesource.com/chromium/blink/+/c06e3ea129f0a16eb4275a2c6bb9e77094bda632 Make RadioNodeList's anonymous indexed getter argument mandatory and drop the [IsIndex] IDL extended attribute. 'optional' and [IsIndex] have no effect on the generated code of anonymous indexed getters: - There is no way for the caller to omit the index - The generated code uses ObjectTemplate::SetIndexedPropertyHandler() and the IndexedPropertyGetterCallback takes a uint32_t in argument. There is no web-exposed behavior change, the generated bindings code is identical.
Created attachment 208608 [details] Patch
Comment on attachment 208608 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=208608&action=review > Source/WebCore/ChangeLog:12 > + This change has strictly no impact on the generated bindings code > + but it simplifies the IDL. Doesn't IsIndex cause INDEX_SIZE_ERR to be thrown when the index is negative?
(In reply to comment #2) > (From update of attachment 208608 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=208608&action=review > > > Source/WebCore/ChangeLog:12 > > + This change has strictly no impact on the generated bindings code > > + but it simplifies the IDL. > > Doesn't IsIndex cause INDEX_SIZE_ERR to be thrown when the index is negative? In theory, yes but not for anonymous indexed getters. As I said in the Changelog, the generated code is *exactly* the same. Also note that throwing an INDEX_SIZE_ERR for negative values in indexed getter would not be according to specification.
Comment on attachment 208608 [details] Patch Clearing flags on attachment: 208608 Committed r154003: <http://trac.webkit.org/changeset/154003>
All reviewed patches have been landed. Closing bug.