Bug 119712 - Remove support for 'pixel' and 'pos' CSSOM prefixes
Summary: Remove support for 'pixel' and 'pos' CSSOM prefixes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords: BlinkMergeCandidate, InRadar, WebExposed
Depends on: 218525
Blocks:
  Show dependency tree / graph
 
Reported: 2013-08-12 18:12 PDT by Ryosuke Niwa
Modified: 2021-02-27 11:51 PST (History)
19 users (show)

See Also:

Attachments
Merges the patch (8.99 KB, patch)
2013-08-12 19:16 PDT, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
Patch (12.33 KB, patch)
2020-10-23 13:43 PDT, Sam Weinig 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (13.13 KB, patch)
2020-10-23 13:53 PDT, Sam Weinig 		no flags Details | Formatted Diff | Diff
Patch (16.06 KB, patch)
2020-10-24 10:55 PDT, Sam Weinig 		no flags Details | Formatted Diff | Diff
Patch (23.40 KB, patch)
2021-02-26 16:54 PST, Sam Weinig 		no flags Details | Formatted Diff | Diff
Patch (12.60 KB, patch)
2021-02-26 16:57 PST, Sam Weinig 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (12.64 KB, patch)
2021-02-26 18:32 PST, Sam Weinig 		no flags Details | Formatted Diff | Diff
Patch (12.75 KB, patch)
2021-02-26 18:34 PST, Sam Weinig 		no flags Details | Formatted Diff | Diff
Patch (12.75 KB, patch)
2021-02-27 09:50 PST, Sam Weinig 		no flags Details | Formatted Diff | Diff
Show Obsolete (8) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2013-08-12 18:12:10 PDT 
Consider merging https://chromium.googlesource.com/chromium/blink/+/7cb1d002fd79604c9e8d0bd810ba6f8f21ca78af

These prefixes are:

1. Non-standard: the CSSOM standard doesn't mention them.

2. Broken: 'pixelWidth' should automagically convert from whatever unit the
   stylesheet specified into CSS pixels[1]. We're currently not doing that at
   all: if an element has a 'width' of 100em, pixelWidth is '100', which is
   probably wildly inaccurate.

3. Not covered by any tests ('fast/dom/CSSStyleDeclaration/css-properties-case-sensitive.html'
   is the only test mentioning these properties, and it only checks
   case-sensitivity: it doesn't validate behavior).

This patch drops support completely.

[1]: http://msdn.microsoft.com/en-us/library/ie/ms531135(v=vs.85).aspx
Comment 1 Ryosuke Niwa 2013-08-12 19:16:50 PDT 
Created attachment 208584 [details]
Merges the patch
Comment 2 Simon Fraser (smfr) 2013-08-12 20:36:22 PDT 
Hmm, would be nice to know if these are used in the wild.
Comment 3 Ryosuke Niwa 2013-08-12 20:42:12 PDT 
(In reply to comment #2)
> Hmm, would be nice to know if these are used in the wild.

Indeed.
Comment 4 Ryosuke Niwa 2013-08-12 20:44:45 PDT 
Here's blink-dev thread: https://groups.google.com/a/chromium.org/forum/#!searchin/blink-dev/pixel$20pos/blink-dev/JS4nH_d1YkA/xd99lydDTfcJ

We might want to discuss this on webkit-dev.
Comment 5 Joseph Pecoraro 2015-11-12 15:29:17 PST 
Comment on attachment 208584 [details]
Merges the patch

I think this is a great idea. I just tested and both Firefox / Chrome no longer support this, so it doesn't seem like too controversial a change. Clearing flags to rebaseline.
Comment 6 Sam Weinig 2020-10-23 13:43:35 PDT 
Created attachment 412209 [details]
Patch
Comment 7 Sam Weinig 2020-10-23 13:53:19 PDT 
Created attachment 412210 [details]
Patch
Comment 8 Sam Weinig 2020-10-24 10:55:10 PDT 
Created attachment 412241 [details]
Patch
Comment 9 EWS 2020-10-25 09:34:51 PDT 
Committed r268957: <https://trac.webkit.org/changeset/268957>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 412241 [details].
Comment 10 Radar WebKit Bug Importer 2020-10-25 09:35:21 PDT 
<rdar://problem/70660490>
Comment 11 WebKit Commit Bot 2020-11-03 10:43:22 PST 
Re-opened since this is blocked by bug 218525
Comment 12 Sam Weinig 2021-02-26 16:54:15 PST Comment hidden (obsolete)
Comment 13 Sam Weinig 2021-02-26 16:57:30 PST Comment hidden (obsolete)
Comment 14 Sam Weinig 2021-02-26 18:32:04 PST Comment hidden (obsolete)
Comment 15 Sam Weinig 2021-02-26 18:34:51 PST Comment hidden (obsolete)
Comment 16 Sam Weinig 2021-02-27 09:50:01 PST 
Created attachment 421748 [details]
Patch
Comment 17 EWS 2021-02-27 11:51:51 PST 
Committed r273627: <https://commits.webkit.org/r273627>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 421748 [details].