RESOLVED FIXED119710
Use the correct preprocessor in shouldRepaintFixedBackgroundsOnScroll() 
https://bugs.webkit.org/show_bug.cgi?id=119710
Summary Use the correct preprocessor in shouldRepaintFixedBackgroundsOnScroll()
Seokju Kwon
Reported 2013-08-12 17:53:40 PDT
Remove unused parameter warning. WebKit/Source/WebCore/rendering/RenderObject.cpp:127:13: warning: unused parameter ‘frameView’ [-Wunused-parameter]
Attachments
Patch (1.49 KB, patch)
2013-08-12 18:05 PDT, Seokju Kwon 		no flags
DetailsFormatted DiffDiff
Patch (1.45 KB, patch)
2013-08-12 18:16 PDT, Seokju Kwon 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Seokju Kwon
Comment 1 2013-08-12 18:05:38 PDT
Created attachment 208579 [details] Patch
Darin Adler
Comment 2 2013-08-12 18:09:16 PDT
Comment on attachment 208579 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=208579&action=review > Source/WebCore/rendering/RenderObject.cpp:129 > -#if !ENABLE(FAST_MOBILE_SCROLLING) && !PLATFORM(QT) > +#if !ENABLE(FAST_MOBILE_SCROLLING) || (ENABLE(FAST_MOBILE_SCROLLING) && !PLATFORM(QT)) That’s the same as just change && to ||, why make it so complicated?
Darin Adler
Comment 3 2013-08-12 18:10:32 PDT
Comment on attachment 208579 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=208579&action=review >> Source/WebCore/rendering/RenderObject.cpp:129 >> +#if !ENABLE(FAST_MOBILE_SCROLLING) || (ENABLE(FAST_MOBILE_SCROLLING) && !PLATFORM(QT)) > > That’s the same as just change && to ||, why make it so complicated? In other words, this is: #if !A || (A && !B) Which is the same as: #if !A || !B
Seokju Kwon
Comment 4 2013-08-12 18:16:29 PDT
(In reply to comment #3) > (From update of attachment 208579 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=208579&action=review > > >> Source/WebCore/rendering/RenderObject.cpp:129 > >> +#if !ENABLE(FAST_MOBILE_SCROLLING) || (ENABLE(FAST_MOBILE_SCROLLING) && !PLATFORM(QT)) > > > > That’s the same as just change && to ||, why make it so complicated? > > In other words, this is: > > #if !A || (A && !B) > > Which is the same as: > > #if !A || !B Just check it explicitly. You're right. It could be so complicated. Thanks.
Seokju Kwon
Comment 5 2013-08-12 18:16:41 PDT
Created attachment 208580 [details] Patch
Seokju Kwon
Comment 6 2013-08-12 18:49:26 PDT
(In reply to comment #4) > (In reply to comment #3) > > (From update of attachment 208579 [details] [details]) > > View in context: https://bugs.webkit.org/attachment.cgi?id=208579&action=review > > > > >> Source/WebCore/rendering/RenderObject.cpp:129 > > >> +#if !ENABLE(FAST_MOBILE_SCROLLING) || (ENABLE(FAST_MOBILE_SCROLLING) && !PLATFORM(QT)) > > > > > > That’s the same as just change && to ||, why make it so complicated? > > > > In other words, this is: > > > > #if !A || (A && !B) > > > > Which is the same as: > > > > #if !A || !B > > Just check it explicitly. You're right. > It could be so complicated. Thanks. Fixed it.
WebKit Commit Bot
Comment 7 2013-08-12 22:46:20 PDT
Comment on attachment 208580 [details] Patch Clearing flags on attachment: 208580 Committed r153974: <http://trac.webkit.org/changeset/153974>
WebKit Commit Bot
Comment 8 2013-08-12 22:46:22 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.