Bug 119702 - Stop making unnecessary copy of CodeBlock Identifier Vector
Summary: Stop making unnecessary copy of CodeBlock Identifier Vector
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Oliver Hunt
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-08-12 15:29 PDT by Oliver Hunt
Modified: 2013-08-12 15:48 PDT (History)
0 users

See Also:

Attachments
Patch (26.36 KB, patch)
2013-08-12 15:32 PDT, Oliver Hunt 		msaboff: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Oliver Hunt 2013-08-12 15:29:52 PDT 
Stop making unnecessary copy of CodeBlock Identifier Vector
Comment 1 Oliver Hunt 2013-08-12 15:32:48 PDT 
Created attachment 208567 [details]
Patch
Comment 2 Oliver Hunt 2013-08-12 15:38:06 PDT 
Committed r153962: <http://trac.webkit.org/changeset/153962>
Comment 3 Geoffrey Garen 2013-08-12 15:48:07 PDT 
Comment on attachment 208567 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=208567&action=review

> Source/JavaScriptCore/bytecode/CodeBlock.h:1090
> +    Vector<Identifier> m_additionalIdentifiers;

Can we call this m_dfgIdentifiers? Would be even better to put this in rare data, since most code blocks are not DFG compiled.