Bug 119700 - Use const AtomicStringImpl* in DocumentOrderedMap
Summary: Use const AtomicStringImpl* in DocumentOrderedMap
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
Depends on:
Blocks: 119701
  Show dependency treegraph
Reported: 2013-08-12 14:37 PDT by Ryosuke Niwa
Modified: 2013-08-12 14:48 PDT (History)
10 users (show)

See Also:

Cleanup (15.36 KB, patch)
2013-08-12 14:41 PDT, Ryosuke Niwa
benjamin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2013-08-12 14:37:13 PDT
Use AtomicStringImpl* in DocumentOrderedMap
Comment 1 Ryosuke Niwa 2013-08-12 14:41:52 PDT
Created attachment 208565 [details]
Comment 2 Benjamin Poulain 2013-08-12 14:46:58 PDT
Comment on attachment 208565 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=208565&action=review

> Source/WebCore/ChangeLog:9
> +        Use const AtomicStringImpl* in DocumentOrderedMap. It caught at least one bug that HTMLNameCollection'
> +        subclasses' nodeMatches were taking const AtomicString& instead of AtomicStringImpl*.

I think you should detail this a little more.
Comment 3 Ryosuke Niwa 2013-08-12 14:48:50 PDT
Committed r153959: <http://trac.webkit.org/changeset/153959>