Bug 119697 - Un-inline dataLog dumpers for IntSize and IntPoint
Summary: Un-inline dataLog dumpers for IntSize and IntPoint
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-08-12 12:46 PDT by Tim Horton
Modified: 2013-08-14 17:24 PDT (History)
9 users (show)

See Also:


Attachments
patch (12.91 KB, patch)
2013-08-12 12:53 PDT, Tim Horton
sam: review+
gtk-ews: commit-queue-
Details | Formatted Diff | Diff
gtk fix (15.57 KB, patch)
2013-08-13 14:51 PDT, Tim Horton
gtk-ews: commit-queue-
Details | Formatted Diff | Diff
gtk fix (16.75 KB, patch)
2013-08-14 11:47 PDT, Tim Horton
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2013-08-12 12:46:08 PDT
Sam pointed out that ignoring my concern about PrintStream.h changes causing most of WebCore to rebuild, adding that header to IntSize/Point.h would always slow down builds. So, add IntSize/Point.cpp.

That said, some people have expressed distaste for this whole thing, so maybe we should just roll it out and put it aside...
Comment 1 Tim Horton 2013-08-12 12:53:49 PDT
Created attachment 208555 [details]
patch
Comment 2 kov's GTK+ EWS bot 2013-08-12 15:32:04 PDT
Comment on attachment 208555 [details]
patch

Attachment 208555 [details] did not pass gtk-ews (gtk):
Output: http://webkit-queues.appspot.com/results/1456180
Comment 3 kov's GTK+ EWS bot 2013-08-12 15:34:30 PDT
Comment on attachment 208555 [details]
patch

Attachment 208555 [details] did not pass gtk-ews (gtk):
Output: http://webkit-queues.appspot.com/results/1453214
Comment 4 Sam Weinig 2013-08-12 22:07:44 PDT
Comment on attachment 208555 [details]
patch

I think you need to update WebCore.vcxproj/WebCore.vcxproj.filters and Target.pri.
Comment 5 Tim Horton 2013-08-13 14:51:22 PDT
Created attachment 208679 [details]
gtk fix
Comment 6 kov's GTK+ EWS bot 2013-08-13 16:17:54 PDT
Comment on attachment 208679 [details]
gtk fix

Attachment 208679 [details] did not pass gtk-ews (gtk):
Output: http://webkit-queues.appspot.com/results/1450653
Comment 7 Tim Horton 2013-08-14 11:47:21 PDT
Created attachment 208750 [details]
gtk fix
Comment 8 WebKit Commit Bot 2013-08-14 17:24:41 PDT
Comment on attachment 208750 [details]
gtk fix

Clearing flags on attachment: 208750

Committed r154084: <http://trac.webkit.org/changeset/154084>
Comment 9 WebKit Commit Bot 2013-08-14 17:24:44 PDT
All reviewed patches have been landed.  Closing bug.