Bug 11968 - BidiContext's m_basicDir is redundant
Summary: BidiContext's m_basicDir is redundant
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 420+
Hardware: Mac OS X 10.4
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-12-25 08:13 PST by mitz
Modified: 2006-12-27 13:34 PST (History)
0 users

See Also:

Attachments
Remove m_basicDir (2.65 KB, patch)
2006-12-26 09:42 PST, mitz 		ggaren: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description mitz 2006-12-25 08:13:12 PST 
BidiContext's m_basicDir is redundant. The only place it's used it can be replaced with style()->direction().
Comment 1 mitz 2006-12-26 09:42:41 PST 
Created attachment 12035 [details]
Remove m_basicDir

No layout test regressions.
Comment 2 Geoffrey Garen 2006-12-26 10:32:05 PST 
Comment on attachment 12035 [details]
Remove m_basicDir

r=me
Comment 3 Sam Weinig 2006-12-27 13:34:19 PST 
Landed in r18439.