Bug 119679 - Remove the cast-align warnings for ARM
Summary: Remove the cast-align warnings for ARM
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
: 118246 (view as bug list)
Depends on:
Blocks:
 
Reported: 2013-08-12 04:08 PDT by Víctor M. Jáquez L.
Modified: 2015-10-06 06:02 PDT (History)
10 users (show)

See Also:

Attachments
list of cast align warnings (18.60 KB, application/x-gzip)
2013-08-12 04:09 PDT, Víctor M. Jáquez L. 		no flags Details
Patch (2.15 KB, patch)
2013-08-19 07:27 PDT, Víctor M. Jáquez L. 		no flags Details | Formatted Diff | Diff
Patch (2.12 KB, patch)
2013-08-19 09:44 PDT, Víctor M. Jáquez L. 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Víctor M. Jáquez L. 2013-08-12 04:08:32 PDT 
Compiling for armhf, gcc (4.7.3) reports ~830 cast-align warnings.

These  warnings might be silenced using reinterpret_cast_ptr<>.
Comment 1 Víctor M. Jáquez L. 2013-08-12 04:09:22 PDT 
Created attachment 208529 [details]
list of cast align warnings
Comment 2 Víctor M. Jáquez L. 2013-08-19 07:27:22 PDT 
Created attachment 209084 [details]
Patch
Comment 3 WebKit Commit Bot 2013-08-19 09:01:47 PDT 
Comment on attachment 209084 [details]
Patch

Rejecting attachment 209084 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 209084, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in Source/WebCore/ChangeLog contains OOPS!.

Full output: http://webkit-queues.appspot.com/results/1515267
Comment 4 Víctor M. Jáquez L. 2013-08-19 09:44:41 PDT 
Created attachment 209094 [details]
Patch
Comment 5 Víctor M. Jáquez L. 2013-08-19 09:45:39 PDT 
Oops, sorry for the OOPS in the ChangeLog :(
Comment 6 WebKit Commit Bot 2013-08-19 10:50:01 PDT 
Comment on attachment 209094 [details]
Patch

Clearing flags on attachment: 209094

Committed r154285: <http://trac.webkit.org/changeset/154285>
Comment 7 WebKit Commit Bot 2013-08-19 10:50:03 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 8 Csaba Osztrogonác 2015-10-06 06:02:46 PDT 
*** Bug 118246 has been marked as a duplicate of this bug. ***