Bug 119676 - Move some Document recalcStyle code to StyleResolveTree
Summary: Move some Document recalcStyle code to StyleResolveTree
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-08-12 03:10 PDT by Antti Koivisto
Modified: 2013-08-12 03:24 PDT (History)
4 users (show)

See Also:

Attachments
patch (4.53 KB, patch)
2013-08-12 03:14 PDT, Antti Koivisto 		kling: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2013-08-12 03:10:32 PDT 
This is the usual starting point for tree resolve.
Comment 1 Antti Koivisto 2013-08-12 03:14:40 PDT 
Created attachment 208524 [details]
patch
Comment 2 Andreas Kling 2013-08-12 03:19:30 PDT 
Comment on attachment 208524 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=208524&action=review

r=me

> Source/WebCore/style/StyleResolveTree.cpp:299
> +    for (Node* child = document->firstChild(); child; child = child->nextSibling()) {
> +        if (!child->isElementNode())
> +            continue;
> +        Element* elementChild = toElement(child);

We should make ElementTraversal support this case.
Comment 3 Antti Koivisto 2013-08-12 03:24:38 PDT 
http://trac.webkit.org/changeset/153938