Bug 119665 - REGRESSION (r153877): Plugin scanning slows creation of WebViews
Summary: REGRESSION (r153877): Plugin scanning slows creation of WebViews
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Plug-ins (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2013-08-11 14:18 PDT by Gustavo Noronha (kov)
Modified: 2013-08-14 13:20 PDT (History)
6 users (show)

See Also:

Attachments
patch (3.93 KB, patch)
2013-08-13 16:15 PDT, Tim Horton 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gustavo Noronha (kov) 2013-08-11 14:18:49 PDT 
According to Tim Horton: "we should make it only-refresh-if-you-already-have-cached-data"
Comment 1 Tim Horton 2013-08-12 14:05:12 PDT 
This is easy for WebKit2 (just don't populatePluginCache() in refreshPlugins(), it'll happen later when it needs to). WebKit1 is another story entirely.
Comment 2 Radar WebKit Bug Importer 2013-08-12 14:31:24 PDT 
<rdar://problem/14716549>
Comment 3 Tim Horton 2013-08-12 14:38:26 PDT 
(In reply to comment #1)
> This is easy for WebKit2 (just don't populatePluginCache() in refreshPlugins(), it'll happen later when it needs to). WebKit1 is another story entirely.

Actually, if we have a dirty bit in WebPlatformStrategies.mm and have some way to tell if the plugin database has been initialized without initializing it, we could do this there without all the complication.
Comment 4 Tim Horton 2013-08-13 16:15:31 PDT 
Created attachment 208688 [details]
patch
Comment 5 WebKit Commit Bot 2013-08-14 13:20:02 PDT 
Comment on attachment 208688 [details]
patch

Clearing flags on attachment: 208688

Committed r154067: <http://trac.webkit.org/changeset/154067>
Comment 6 WebKit Commit Bot 2013-08-14 13:20:04 PDT 
All reviewed patches have been landed.  Closing bug.