[GTK] [Stable] webkitgtk-2.0.4 gamepad support and undefined reference to g_udev_…

[Paul Seidler]

Created attachment 208487 [details]
compressed build log including error

--enable-gamepad leads here to:

Source/WebCore/platform/gtk/.libs/libWebCorePlatform_la-GamepadsGtk.o: In function `WebCore::GamepadsGtk::isGamepadDevice(_GUdevDevice*)':
GamepadsGtk.cpp:(.text+0x3e2): undefined reference to `g_udev_device_get_device_file'
GamepadsGtk.cpp:(.text+0x3ed): undefined reference to `g_udev_device_get_sysfs_path'
GamepadsGtk.cpp:(.text+0x420): undefined reference to `g_udev_device_has_property'
GamepadsGtk.cpp:(.text+0x433): undefined reference to `g_udev_device_has_property'
Source/WebCore/platform/gtk/.libs/libWebCorePlatform_la-GamepadsGtk.o: In function `WebCore::GamepadsGtk::onUEventCallback(_GUdevClient*, char*, _GUdevDevice*, void*)':
GamepadsGtk.cpp:(.text+0xbd4): undefined reference to `g_udev_device_get_device_file'
Source/WebCore/platform/gtk/.libs/libWebCorePlatform_la-GamepadsGtk.o: In function `WebCore::GamepadsGtk::GamepadsGtk(unsigned int)':
GamepadsGtk.cpp:(.text+0xd3d): undefined reference to `g_udev_client_new'
GamepadsGtk.cpp:(.text+0xda0): undefined reference to `g_udev_client_query_by_subsystem'
GamepadsGtk.cpp:(.text+0xdb1): undefined reference to `g_udev_device_get_type'
GamepadsGtk.cpp:(.text+0xe01): undefined reference to `g_udev_device_get_device_file'
collect2: error: ld returned 1 exit status
make[1]: *** [Programs/WebKitPluginProcess] Error 1

Some -lgudev-1.0 or GAMEPAD_LIBS seems to be missing

[Alberto Garcia]

It seems to work fine in my environment, what version of gudev do you have?

[Alberto Garcia]

Ah, I see, this is fixed in trunk (bug 114901) but fails in the stable branch.

Carlos, we need to add this to Programs_WebKitPluginProcess_LDADD:

--- Source/WebKit2/GNUmakefile.am.orig  2013-09-13 17:50:37.461815213 +0300
+++ Source/WebKit2/GNUmakefile.am       2013-09-13 17:38:39.415056167 +0300
@@ -610,6 +610,7 @@
        $(CAIRO_LIBS) \
        $(COVERAGE_LDFLAGS) \
        $(FREETYPE_LIBS) \
+       $(GAMEPAD_LIBS) \
        $(GEOCLUE_LIBS) \
        $(GLIB_LIBS) \
        $(GSTREAMER_LIBS) \

I'll update the wiki.

[Carlos Garcia Campos]

(In reply to comment #2)
> Ah, I see, this is fixed in trunk (bug 114901) but fails in the stable branch.
> 
> Carlos, we need to add this to Programs_WebKitPluginProcess_LDADD:
> 
> --- Source/WebKit2/GNUmakefile.am.orig  2013-09-13 17:50:37.461815213 +0300
> +++ Source/WebKit2/GNUmakefile.am       2013-09-13 17:38:39.415056167 +0300
> @@ -610,6 +610,7 @@
>         $(CAIRO_LIBS) \
>         $(COVERAGE_LDFLAGS) \
>         $(FREETYPE_LIBS) \
> +       $(GAMEPAD_LIBS) \
>         $(GEOCLUE_LIBS) \
>         $(GLIB_LIBS) \
>         $(GSTREAMER_LIBS) \
> 
> I'll update the wiki.

I'm confused, bug 114901 landed in r149169 that is previous to the branch point r154665 and Programs_WebKitPluginProcess_LDADD already have GAMEPAD_LIBS in 2.2 branch

[Alberto Garcia]

(In reply to comment #3)
> I'm confused, bug 114901 landed in r149169 that is previous to the
> branch point r154665 and Programs_WebKitPluginProcess_LDADD already
> have GAMEPAD_LIBS in 2.2 branch

Never mind, Gustavo fixed this already: http://trac.webkit.org/changeset/154060

[Carlos Garcia Campos]

(In reply to comment #4)
> (In reply to comment #3)
> > I'm confused, bug 114901 landed in r149169 that is previous to the
> > branch point r154665 and Programs_WebKitPluginProcess_LDADD already
> > have GAMEPAD_LIBS in 2.2 branch
> 
> Never mind, Gustavo fixed this already: http://trac.webkit.org/changeset/154060

Ah, ok, this only applied to the 2.0 branch, not the 2.2 one.