Bug 119658 – Remove didNewFirstVisuallyNonEmptyLayout from WebKit2

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit API

[Beth Dakin]

We should remove or at least deprecate didNewFirstVisuallyNonEmptyLayout from WebKit2. We think it will be okay to remove it entirely, so I will try that first.

[Beth Dakin]

Created attachment 208486 [details]
Patch

[Darin Adler]

Won’t this create problems for someone using an older Safari with a newer WebKit?

[Beth Dakin]

(In reply to comment #2)
> Won’t this create problems for someone using an older Safari with a newer WebKit?

Sam's opinion was that the lost functionality would be acceptable in nightly builds, and that if we did find it to be a bigger problem than anticipated, we could roll this patch out and deprecate the function instead.

[Darin Adler]

(In reply to comment #3)
> (In reply to comment #2)
> > Won’t this create problems for someone using an older Safari with a newer WebKit?
> 
> Sam's opinion was that the lost functionality would be acceptable in nightly builds

Got it. I couldn’t tell from anything in the patch that we’d considered this when deciding it was OK. Even if it was just your opinion, I’d be fine with it. From the patch it wasn’t clear it was an intentional decision.

[Darin Adler]

Comment on attachment 208486 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=208486&action=review

> Source/WebKit2/UIProcess/WebLoaderClient.h:66
> +    // FIXME: We should consider removing didFirstVisuallyNonEmptyLayoutForFrame since its functionality is replaced by didLayout.

I would like a shorter comment. I’m not sure the word “functionality” adds anything here.

    // FIXME: Remove didFirstVisuallyNonEmptyLayoutForFrame; clients should use didLayout instead.

[Beth Dakin]

Thanks Darin! I shortened the comment and added some information to the Changelog about why we think this is okay to remove.

I committed the change with http://trac.webkit.org/changeset/153956