Bug 119651 - [GObject] Wrap KeyboardEvent
Summary: [GObject] Wrap KeyboardEvent
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gustavo Noronha (kov)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-08-09 20:28 PDT by Gustavo Noronha (kov)
Modified: 2013-08-10 08:44 PDT (History)
8 users (show)

See Also:

Attachments
Patch (4.98 KB, patch)
2013-08-09 20:32 PDT, Gustavo Noronha (kov) 		cdumez: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gustavo Noronha (kov) 2013-08-09 20:28:51 PDT 
[GObject] Wrap KeyboardEvent
Comment 1 Gustavo Noronha (kov) 2013-08-09 20:32:38 PDT 
Created attachment 208471 [details]
Patch
Comment 2 Gustavo Noronha (kov) 2013-08-09 20:34:12 PDT 
This is required for this to work: https://bugzilla.gnome.org/show_bug.cgi?id=675060 (A UI to show users which have passwords saved for a site in Epiphany)
Comment 3 Chris Dumez 2013-08-09 22:47:40 PDT 
Comment on attachment 208471 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=208471&action=review

> Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm:114
> +    return "Event" if $parent eq "UIEvent" or $parent eq "MouseEvent" or $parent eq "KeyboardEvent";

Could we simply use $codeGenerator->InheritsInterface("Event") ? This does not look very scalable.
Comment 4 Gustavo Noronha (kov) 2013-08-10 08:44:17 PDT 
Committed r153921: <http://trac.webkit.org/changeset/153921>