Bug 119644 - [iOS] isMainThread implementation with USE(WEB_THREAD)
Summary: [iOS] isMainThread implementation with USE(WEB_THREAD)
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-08-09 17:02 PDT by Joseph Pecoraro
Modified: 2013-08-12 10:47 PDT (History)
6 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (5.83 KB, patch)
2013-08-09 17:05 PDT, Joseph Pecoraro 		benjamin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2013-08-09 17:02:47 PDT 
At the 2013 WebKit Contributors Meeting this year one of the discussions was upstreaming iOS WebKit:
<https://docs.google.com/document/d/1jsqXPcwOkBo4L8taB_rmSY8oAZFCaGJ1CU20PI6p0kQ/edit?pli=1>

Discussion: What do we do about ASSERT(isMainThread())?
DECISION: Leave it named isMainThread()…

On iOS isMainThread() means that the current thread is either the MainThread or WebThread and the current thread has the WebThreadLock.
Comment 1 Joseph Pecoraro 2013-08-09 17:05:21 PDT 
Created attachment 208463 [details]
[PATCH] Proposed Fix
Comment 2 WebKit Commit Bot 2013-08-09 17:08:24 PDT 
Attachment 208463 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WTF/ChangeLog', u'Source/WTF/wtf/ios/WebCoreThread.cpp', u'Source/WTF/wtf/ios/WebCoreThread.h', u'Source/WTF/wtf/mac/MainThreadMac.mm']" exit_code: 1
Source/WTF/wtf/ios/WebCoreThread.h:28:  #ifndef header guard has wrong style, please use: WTF_WebCoreThread_h  [build/header_guard] [5]
Total errors found: 1 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Joseph Pecoraro 2013-08-12 10:47:02 PDT 
Committed <http://trac.webkit.org/changeset/153950>.