RESOLVED FIXED 119631
[webkitpy] perf profiler attaches to WKTR after the WebProcess was launched 
https://bugs.webkit.org/show_bug.cgi?id=119631
Summary [webkitpy] perf profiler attaches to WKTR after the WebProcess was launched
Zan Dobersek
Reported 2013-08-09 08:25:32 PDT
[webkitpy] perf profiler attaches to WKTR after the WebProcess was launched
Attachments
Patch (8.74 KB, patch)
2013-08-09 08:45 PDT, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Patch (11.44 KB, patch)
2013-09-10 03:45 PDT, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Zan Dobersek
Comment 1 2013-08-09 08:45:36 PDT
Created attachment 208437 [details] Patch
Ryosuke Niwa
Comment 2 2013-09-09 11:59:16 PDT
Comment on attachment 208437 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=208437&action=review > Tools/Scripts/webkitpy/common/system/profiler.py:-162 > - if perf_exitcode is None: # This should always be the case, unless perf error'd out early. > - self._host.executive.interrupt(self._perf_process.pid) > - > - perf_exitcode = self._perf_process.wait() > - if perf_exitcode not in (0, -2): # The exit code should always be -2, as we're always interrupting perf. > - print "'perf record' failed (exit code: %i), can't process results:" % perf_exitcode > - return Who is catching the error now? > Tools/Scripts/webkitpy/port/driver.py:218 > + if self._port.get_option('wrapper'): Why don't we store this on a temporary variable?
Zan Dobersek
Comment 3 2013-09-10 03:45:24 PDT
Created attachment 211188 [details] Patch
Zan Dobersek
Comment 4 2013-09-15 02:25:54 PDT
Thanks!
Zan Dobersek
Comment 5 2013-09-15 02:28:50 PDT
Comment on attachment 211188 [details] Patch Clearing flags on attachment: 211188 Committed r155803: <http://trac.webkit.org/changeset/155803>
Zan Dobersek
Comment 6 2013-09-15 02:28:56 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.