Bug 119629 – Move StyleResolver static functions to Style namespace

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Antti Koivisto]

Shrink down StyleResolver.

[Antti Koivisto]

Created attachment 208435 [details]
patch

[Antti Koivisto]

Created attachment 208436 [details]
rebased

The patch is big because StyleResolver.cpp was svn cp'd to keep history.

[Antti Koivisto]

Created attachment 208442 [details]
lets try without move

[WebKit Commit Bot]

Attachment 208442 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/css/DeprecatedStyleBuilder.cpp', u'Source/WebCore/css/StyleResolver.cpp', u'Source/WebCore/css/StyleResolver.h', u'Source/WebCore/dom/Document.cpp', u'Source/WebCore/editing/EditingStyle.cpp', u'Source/WebCore/html/HTMLLinkElement.cpp', u'Source/WebCore/rendering/style/RenderStyle.cpp', u'Source/WebCore/rendering/style/RenderStyle.h', u'Source/WebCore/rendering/svg/RenderSVGInlineText.cpp', u'Source/WebCore/style/StyleFontSizeFunctions.cpp', u'Source/WebCore/style/StyleFontSizeFunctions.h', u'Source/WebCore/style/StyleResolveForDocument.cpp', u'Source/WebCore/style/StyleResolveForDocument.h']" exit_code: 1
Source/WebCore/style/StyleFontSizeFunctions.cpp:109:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/style/StyleFontSizeFunctions.cpp:110:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/style/StyleFontSizeFunctions.cpp:111:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/style/StyleFontSizeFunctions.cpp:112:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/style/StyleFontSizeFunctions.cpp:113:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/style/StyleFontSizeFunctions.cpp:114:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/style/StyleFontSizeFunctions.cpp:115:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/style/StyleFontSizeFunctions.cpp:116:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/style/StyleFontSizeFunctions.cpp:126:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/style/StyleFontSizeFunctions.cpp:127:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/style/StyleFontSizeFunctions.cpp:128:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/style/StyleFontSizeFunctions.cpp:129:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/style/StyleFontSizeFunctions.cpp:130:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/style/StyleFontSizeFunctions.cpp:131:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/style/StyleFontSizeFunctions.cpp:132:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/style/StyleFontSizeFunctions.cpp:133:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 16 in 14 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Early Warning System Bot]

Comment on attachment 208442 [details]
lets try without move

Attachment 208442 [details] did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/1385327

[Early Warning System Bot]

Comment on attachment 208442 [details]
lets try without move

Attachment 208442 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/1413246

[Build Bot]

Comment on attachment 208442 [details]
lets try without move

Attachment 208442 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/1353529

[EFL EWS Bot]

Comment on attachment 208442 [details]
lets try without move

Attachment 208442 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/1401263

[kov's GTK+ EWS bot]

Comment on attachment 208442 [details]
lets try without move

Attachment 208442 [details] did not pass gtk-ews (gtk):
Output: http://webkit-queues.appspot.com/results/1413251

[EFL EWS Bot]

Comment on attachment 208442 [details]
lets try without move

Attachment 208442 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/1412236

[Build Bot]

Comment on attachment 208442 [details]
lets try without move

Attachment 208442 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/1405256

[Antti Koivisto]

Created attachment 208443 [details]
build files and fixes

[Build Bot]

Comment on attachment 208443 [details]
build files and fixes

Attachment 208443 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/1359542

[Build Bot]

Comment on attachment 208443 [details]
build files and fixes

Attachment 208443 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/1412250

[Antti Koivisto]

http://trac.webkit.org/changeset/153906