Bug 119629 - Move StyleResolver static functions to Style namespace
Summary: Move StyleResolver static functions to Style namespace
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-08-09 07:23 PDT by Antti Koivisto
Modified: 2013-08-09 12:43 PDT (History)
10 users (show)

See Also:

Attachments
patch (402.53 KB, patch)
2013-08-09 08:11 PDT, Antti Koivisto 		no flags Details | Formatted Diff | Diff
rebased (402.57 KB, patch)
2013-08-09 08:18 PDT, Antti Koivisto 		sam: review+
Details | Formatted Diff | Diff
lets try without move (59.48 KB, patch)
2013-08-09 10:51 PDT, Antti Koivisto 		webkit-ews: commit-queue-
Details | Formatted Diff | Diff
build files and fixes (62.60 KB, patch)
2013-08-09 11:41 PDT, Antti Koivisto 		kling: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2013-08-09 07:23:16 PDT 
Shrink down StyleResolver.
Comment 1 Antti Koivisto 2013-08-09 08:11:19 PDT 
Created attachment 208435 [details]
patch
Comment 2 Antti Koivisto 2013-08-09 08:18:44 PDT 
Created attachment 208436 [details]
rebased

The patch is big because StyleResolver.cpp was svn cp'd to keep history.
Comment 3 Antti Koivisto 2013-08-09 10:51:32 PDT 
Created attachment 208442 [details]
lets try without move
Comment 4 WebKit Commit Bot 2013-08-09 10:53:54 PDT 
Attachment 208442 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/css/DeprecatedStyleBuilder.cpp', u'Source/WebCore/css/StyleResolver.cpp', u'Source/WebCore/css/StyleResolver.h', u'Source/WebCore/dom/Document.cpp', u'Source/WebCore/editing/EditingStyle.cpp', u'Source/WebCore/html/HTMLLinkElement.cpp', u'Source/WebCore/rendering/style/RenderStyle.cpp', u'Source/WebCore/rendering/style/RenderStyle.h', u'Source/WebCore/rendering/svg/RenderSVGInlineText.cpp', u'Source/WebCore/style/StyleFontSizeFunctions.cpp', u'Source/WebCore/style/StyleFontSizeFunctions.h', u'Source/WebCore/style/StyleResolveForDocument.cpp', u'Source/WebCore/style/StyleResolveForDocument.h']" exit_code: 1
Source/WebCore/style/StyleFontSizeFunctions.cpp:109:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/style/StyleFontSizeFunctions.cpp:110:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/style/StyleFontSizeFunctions.cpp:111:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/style/StyleFontSizeFunctions.cpp:112:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/style/StyleFontSizeFunctions.cpp:113:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/style/StyleFontSizeFunctions.cpp:114:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/style/StyleFontSizeFunctions.cpp:115:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/style/StyleFontSizeFunctions.cpp:116:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/style/StyleFontSizeFunctions.cpp:126:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/style/StyleFontSizeFunctions.cpp:127:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/style/StyleFontSizeFunctions.cpp:128:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/style/StyleFontSizeFunctions.cpp:129:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/style/StyleFontSizeFunctions.cpp:130:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/style/StyleFontSizeFunctions.cpp:131:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/style/StyleFontSizeFunctions.cpp:132:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/style/StyleFontSizeFunctions.cpp:133:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 16 in 14 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Early Warning System Bot 2013-08-09 10:59:27 PDT 
Comment on attachment 208442 [details]
lets try without move

Attachment 208442 [details] did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/1385327
Comment 6 Early Warning System Bot 2013-08-09 10:59:35 PDT 
Comment on attachment 208442 [details]
lets try without move

Attachment 208442 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/1413246
Comment 7 Build Bot 2013-08-09 11:01:14 PDT 
Comment on attachment 208442 [details]
lets try without move

Attachment 208442 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/1353529
Comment 8 EFL EWS Bot 2013-08-09 11:07:56 PDT 
Comment on attachment 208442 [details]
lets try without move

Attachment 208442 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/1401263
Comment 9 kov's GTK+ EWS bot 2013-08-09 11:09:41 PDT 
Comment on attachment 208442 [details]
lets try without move

Attachment 208442 [details] did not pass gtk-ews (gtk):
Output: http://webkit-queues.appspot.com/results/1413251
Comment 10 EFL EWS Bot 2013-08-09 11:15:53 PDT 
Comment on attachment 208442 [details]
lets try without move

Attachment 208442 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/1412236
Comment 11 Build Bot 2013-08-09 11:32:06 PDT 
Comment on attachment 208442 [details]
lets try without move

Attachment 208442 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/1405256
Comment 12 Antti Koivisto 2013-08-09 11:41:45 PDT 
Created attachment 208443 [details]
build files and fixes
Comment 13 Build Bot 2013-08-09 12:01:33 PDT 
Comment on attachment 208443 [details]
build files and fixes

Attachment 208443 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/1359542
Comment 14 Build Bot 2013-08-09 12:07:06 PDT 
Comment on attachment 208443 [details]
build files and fixes

Attachment 208443 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/1412250
Comment 15 Antti Koivisto 2013-08-09 12:43:19 PDT 
http://trac.webkit.org/changeset/153906