Bug 119624 – Remove home-brewed nullptr

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Template Framework

[Mikhail Pozdnyakov]

At the moment nullptr can be used only for smart pointers initialization, because WTF version of std::nullptr_t is restricted. Basing its implementation on example from http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2007/n2431.pdf would let us to use it with plain pointers as well.

[Mikhail Pozdnyakov]

Created attachment 208426 [details]
patch

[Anders Carlsson]

Comment on attachment 208426 [details]
patch

I’m pretty sure we can rip out the NullPtr emulation and just use the builtin C++11 nullptr now. Can you try doing that instead?

[Mikhail Pozdnyakov]

(In reply to comment #2)
> (From update of attachment 208426 [details])
> I’m pretty sure we can rip out the NullPtr emulation and just use the builtin C++11 nullptr now. Can you try doing that instead?

I have tried. EFL port at least does not build.

/media/ssd/WebKit/Source/WTF/wtf/PassOwnArrayPtr.h:45:35: error: function definition does not declare parameters
In file included from /media/ssd/WebKit/Tools/ImageDiff/efl/ImageDiff.cpp:45:0:
/media/ssd/WebKit/Source/WTF/wtf/OwnArrayPtr.h:70:42: error: declaration of 'operator=' as non-function
/media/ssd/WebKit/Source/WTF/wtf/OwnArrayPtr.h:70:26: error: expected ';' at end of member declaration
/media/ssd/WebKit/Source/WTF/wtf/OwnArrayPtr.h:70:42: error: function definition does not declare parameters
In file included from /media/ssd/WebKit/Tools/ImageDiff/efl/ImageDiff.cpp:46:0:
/media/ssd/WebKit/Source/WTF/wtf/OwnPtr.h:50:30: error: function definition does not declare parameters
/media/ssd/WebKit/Source/WTF/wtf/OwnPtr.h:81:41: error: declaration of 'operator=' as non-function
/media/ssd/WebKit/Source/WTF/wtf/OwnPtr.h:81:25: error: expected ';' at end of member declaration
/media/ssd/WebKit/Source/WTF/wtf/OwnPtr.h:81:41: error: function definition does not declare parameters

Could you please re-visit the patch?

[Anders Carlsson]

(In reply to comment #3)
> (In reply to comment #2)
> > (From update of attachment 208426 [details] [details])
> > I’m pretty sure we can rip out the NullPtr emulation and just use the builtin C++11 nullptr now. Can you try doing that instead?
> 
> I have tried. EFL port at least does not build.
> 
> /media/ssd/WebKit/Source/WTF/wtf/PassOwnArrayPtr.h:45:35: error: function definition does not declare parameters

Can you check if COMPILER_SUPPORTS(CXX_NULLPTR) is true? 

> Could you please re-visit the patch?

Let’s try to figure out why C++11 nullptr doesn’t work instead!

[Mikhail Pozdnyakov]

Created attachment 211309 [details]
patch v2

Removed home-brewed nullptr.

[Anders Carlsson]

Comment on attachment 211309 [details]
patch v2

Excellent! Could you please add the rationale to the ChangeLog? Something like how we can just use the standard C++11 nullptr and sd::nullptr_t types now.

[Mikhail Pozdnyakov]

Created attachment 211413 [details]
to be landed

Added rational to change log.

[WebKit Commit Bot]

Comment on attachment 211413 [details]
to be landed

Clearing flags on attachment: 211413

Committed r155604: <http://trac.webkit.org/changeset/155604>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Anders Carlsson]

*** Bug 120966 has been marked as a duplicate of this bug. ***