Bug 119613 - move-by-word-visually-multi-space.html takes 21s and spends most of its time doing spelling and grammar checking
Summary: move-by-word-visually-multi-space.html takes 21s and spends most of its time ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-08-08 20:50 PDT by Simon Fraser (smfr)
Modified: 2013-08-09 09:52 PDT (History)
4 users (show)

See Also:


Attachments
Patch (5.50 KB, patch)
2013-08-08 21:19 PDT, Simon Fraser (smfr)
no flags Details | Formatted Diff | Diff
Sample (2.54 MB, text/plain)
2013-08-08 21:21 PDT, Simon Fraser (smfr)
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2013-08-08 20:50:29 PDT
move-by-word-visually-multi-space.html is a very slow test: 21s on the bots.

Sampling shows that it spends most of its time doing spell checking.
Comment 1 Simon Fraser (smfr) 2013-08-08 20:52:47 PDT
Doing
    internals.setContinuousSpellCheckingEnabled(false);
takes the runtime down from 14s to 4s on my machine.
Comment 2 Ryosuke Niwa 2013-08-08 20:58:37 PDT
(In reply to comment #0)
> move-by-word-visually-multi-space.html is a very slow test: 21s on the bots.
> 
> Sampling shows that it spends most of its time doing spell checking.

That's really bad because we should never be spellchecking content that wasn't entered by the user.

Do you have any traces for this test?
Comment 3 Simon Fraser (smfr) 2013-08-08 21:19:46 PDT
Created attachment 208394 [details]
Patch
Comment 4 Simon Fraser (smfr) 2013-08-08 21:21:46 PDT
Created attachment 208395 [details]
Sample
Comment 5 WebKit Commit Bot 2013-08-09 09:52:26 PDT
Comment on attachment 208394 [details]
Patch

Clearing flags on attachment: 208394

Committed r153897: <http://trac.webkit.org/changeset/153897>
Comment 6 WebKit Commit Bot 2013-08-09 09:52:28 PDT
All reviewed patches have been landed.  Closing bug.